Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adds support for Vesternet Zigbee Sensors #7020

Closed
wants to merge 0 commits into from

Conversation

martyn-vesternet
Copy link
Contributor

VES-ZB-DOR-025 Door and window sensor, exposes contact, tamper, battery and link quality
VES-ZB-PIR-021 Motion sensor, exposes occupancy, tamper, battery and link quality
VES-ZB-TEM-027 Temperature and humidity sensor, exposes temperature, humidity, battery and link quality

src/devices/vesternet.ts Outdated Show resolved Hide resolved
@Koenkk
Copy link
Owner

Koenkk commented Feb 6, 2024

I refactored the code a bit, can you check if all is ok?

@martyn-vesternet
Copy link
Contributor Author

Those changes seem to impact the reporting I'm configuring for each device though?

I try to set configuration so that it's a compromise on functionality / battery life and so that it matches that which I set on other platforms (Hubitat, SmartThings & Homey) for the Vesternet devices.

I prefer these for the humidity / temperature sensors:

min: 60, max: 1800, change: 100 ( 1 degree / percent change, every 60 seconds at most, every 30 minutes at least )

whereas the config from "modernExtend" seems to be:

min: '10_SECONDS', max: '1_HOUR', change: 100

IMHO 10 seconds is too frequent, it will generate many reports in environments where the temperature / humidity changes rapidly.

And for battery:

min: 600, max: 21600, change: 2 ( 1 percent change, every 10 minutes at most, every 6 hours at least )

(I just noticed I didn't set those correctly in my commit, so I will update them)

whereas the config from "modernExtend" seems to be:

min: '1_HOUR', max: 'MAX', change: 10

Which seems to only report on a 5 percent change and only report every 18 hours if no change?

@Koenkk
Copy link
Owner

Koenkk commented Feb 10, 2024

I prefer these for the humidity / temperature sensors:

Agree about these ones, please update the defaults.

Which seems to only report on a 5 percent change and only report every 18 hours if no change?

Yes, because it's unlikely that a sensors consumes more than 5 percent of battery every 18 hours

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants