-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hotfix(Sengled): return RGB colors to bulbs and convert to modern extend #7317
Conversation
Marking as draft before testing confirmationCan somebody please test any affected Sengled bulb with this temporary external converter? I need to now if they support hs, xy or both color modes. Replace const {light} = require('zigbee-herdsman-converters/lib/modernExtend');
const definition = {
zigbeeModel: ['E21-N1EA'],
model: 'E21-N1EA',
description: 'Smart LED multicolor A19 bulb',
vendor: 'Sengled',
extend: [light({effect: false, powerOnBehavior: false, colorTemp: {range: [154, 500]}, color: {modes: ['xy', 'hs']}})],
}
module.exports = definition; |
UPDHS color mode is confirmed to be supported. Re-opeing PR as ready for merge. |
I tested my Sengled E12-N1E BR30 bulbs with the following external converter: const {light, electricityMeter, forcePowerSource} = require('zigbee-herdsman-converters/lib/modernExtend');
const definition = {
zigbeeModel: ['E12-N1E'],
model: 'E12-N1E',
vendor: 'Sengled',
description: 'Smart LED multicolor (BR30)',
extend: [
light({effect: false, powerOnBehavior: false, colorTemp: {range: [154, 500]}, color: {modes: ['hs']}}),
electricityMeter({cluster: 'metering'}),
forcePowerSource({powerSource: 'Mains (single phase)'})
]
};
module.exports = definition; Using only When I set At least for my bulbs, it doesn't look like they respond to "color_mode": "hs" Setting |
Reverted to XY color mode for all lights. As was done before the bug. |
Many thanks! Seems I was sleeping during #7168 😴 |
This bug was introduced in #7168
Also converted all Sengled devices to modern extend along the way :)
PS
I'm not sure aboutcolor: true
since previous legacy extend technically only exposed XY color by default.