Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup old logger leftovers. #7319

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Cleanup old logger leftovers. #7319

merged 1 commit into from
Apr 3, 2024

Conversation

Nerivec
Copy link
Contributor

@Nerivec Nerivec commented Apr 2, 2024

  • Silence console (default logger) during Jest tests.
  • Remove logger params in favor of module.
  • Fix Typescript typing.
  • Fix a couple of missing namespaces.
  • Fix tests.

Another small PR 😄

@Koenkk Koenkk merged commit 9c1cd72 into Koenkk:master Apr 3, 2024
1 of 2 checks passed
@Koenkk
Copy link
Owner

Koenkk commented Apr 3, 2024

Thanks again!

@Nerivec Nerivec deleted the logger-cleanup branch April 3, 2024 18:07
@Koenkk Koenkk mentioned this pull request Apr 3, 2024
Merged
@Nerivec Nerivec mentioned this pull request Apr 4, 2024
Merged
@Koenkk Koenkk mentioned this pull request Apr 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nerivec @Koenkk