Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more Feibit device models #7889

Merged
merged 17 commits into from
Aug 29, 2024
Merged

Add more Feibit device models #7889

merged 17 commits into from
Aug 29, 2024

Conversation

snksos
Copy link
Contributor

@snksos snksos commented Aug 21, 2024

No description provided.

test/fromZigbee.test.js Outdated Show resolved Hide resolved
src/devices/feibit.ts Outdated Show resolved Hide resolved
src/devices/feibit.ts Outdated Show resolved Hide resolved
src/devices/feibit.ts Outdated Show resolved Hide resolved
@snksos snksos requested a review from Koenkk August 22, 2024 04:01
@snksos snksos changed the title Add more Feibit device models & Fix test/fromZigbee.test.js require bug Add more Feibit device models Aug 22, 2024
src/devices/feibit.ts Outdated Show resolved Hide resolved
@Koenkk
Copy link
Owner

Koenkk commented Aug 22, 2024

Note to self: commit message: feat(add): TSKT106W-M1, SZSN325W-Q, TSKT114W-S1, NZRC106W-M2, SZT211_AW-P1, SSS401ZB-T, TZSC302W-V1, TSKT222W-H4, TCUR218W-V1

@Koenkk
Copy link
Owner

Koenkk commented Aug 22, 2024

Could you also submit a picture for the docs? This can be done by:

  1. Create a fork by clicking here
  2. Go to the public/images/devices directory, Add file -> Upload files
  3. Upload the files and press Commit changes
  4. Press Contribute -> Open pull request -> update title/description -> Create pull request

Make sure that:

  • The filename is MODEL.png (e.g TSKT106W-M1.png)
  • The size is 512x512
  • The background is transparent (use e.g. Adobe remove background)

@snksos snksos requested a review from Koenkk August 24, 2024 00:11
@Koenkk
Copy link
Owner

Koenkk commented Aug 26, 2024

Code looks good now, could you also make a PR for the pictures?

@snksos
Copy link
Contributor Author

snksos commented Aug 27, 2024

Code looks good now, could you also make a PR for the pictures?

Yes, We are taking photos and organizing documents

@snksos
Copy link
Contributor Author

snksos commented Aug 29, 2024

Code looks good now, could you also make a PR for the pictures?

Hi, pictures PR has been submitted
Koenkk/zigbee2mqtt.io#2980

@Koenkk Koenkk merged commit 00c1237 into Koenkk:master Aug 29, 2024
2 checks passed
@Koenkk
Copy link
Owner

Koenkk commented Aug 29, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants