Improve handling of greenpower devices on larger networks #488
Conversation
src/controller/controller.ts
Outdated
| // Process gpDevice as actual device in event of encapsulated notification via unicast | ||
| if (gpDevice) { | ||
| gpDevice.updateLastSeen(); | ||
| gpDevice.implicitCheckin(); |
There was a problem hiding this comment.
I don't think we have to call implicit checking for gp devices, this is only relevant for devices where commands can be send to.
There was a problem hiding this comment.
I can remove this, no problem.
|
CI is failing because of the test coverage. You can check it locally by running zigbee-herdsman/test/controller.test.ts Line 3630 in 8abf23a |
|
Still chipping away at this, but a little time-poor right now, I'll let know once I've completed the new test cases |
pklokke
force-pushed
the
greenpower_unicast
branch
2 times, most recently
from
0b4d025
to
bfa3a7d
Compare
- Allow forwarding of unicast encapsulated GPDF if permitjoin is used on single router/proxy - This allows GPDs to not spam broadcast traffic in larger networks, which can bog down certain lighting scenarios - Permit join using all routers retains existing behaviour - Remove GPD proxy entries from routers when removed - Extended frames, and added mechanism for optional attributes via 'BitMaskSet' and 'BitFieldEnum'
pklokke
force-pushed
the
greenpower_unicast
branch
from
bfa3a7d
to
79e6e78
Compare
|
Took a bit longer than expected, needed to refactor some of the optional attribute things, and had to develop the test cases more. Now it works in theory and in practice I believe. Whenever you're ready @Koenkk , I'd appreciate a review. :-) |
|
Looks good, big thanks! |
router/proxy
can bog down certain lighting scenarios