Flush logger before exiting process #10905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuaspence
force-pushed
the
flush-logger
branch
from
3baa15e
to
4d6a9ad
Compare
Koenkk
reviewed
Jan 20, 2022
lib/controller.ts
Outdated
| // Workaround for https://github.com/winstonjs/winston/issues/1629 | ||
| await new Promise<void>((resolve, reject) => { | ||
| logger.winston.on('finish', () => { | ||
| setTimeout(() => resolve(), 1000); |
There was a problem hiding this comment.
If I understand correctly, this will always increase the shutdown sequence by 1 second, could this be decreased?
There was a problem hiding this comment.
That is my understanding as well. Possibly it could be decreased but since winston writing to file is async there's no real safe value. The shorter the timeout the more likely that the logs won't be written to disk.
There was a problem hiding this comment.
I tried a few different options that wouldn't add unnecessary delay to shutdown but unfortunately wasn't able to get anything else to work
There was a problem hiding this comment.
I just checked, setTimeout(() => resolve(), 10); also fixes it, could you also test this?
joshuaspence
force-pushed
the
flush-logger
branch
2 times, most recently
from
598ea23
to
bcf09cc
Compare
joshuaspence
force-pushed
the
flush-logger
branch
from
bcf09cc
to
7dde5a0
Compare
|
nice solution, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am using the
filelogger without theconsolelogger and if Z2M is unable to start then nothing is logged becauseprocess.exit(1)is calling and WInston doesn't flush async logs when this happens (see winstonjs/winston#1629).With console logging enabled:
With file logging: