Check tty before colorizing output #11645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That it is been covered doesn't necessarily mean that it is tested (asserted). Anyway, this looks fine to me; will merge it after the next release (2 march) |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm forwarding all logs from the host zigbee2mqtt is installed on over syslog to a graylog instance. As is, that means that terminal colours are being shown:
zigbee2mqtt npm[8991]: #033[32mZigbee2MQTT:info #033[39m 2022-02-27 17:07:06: Stopping zigbee-herdsman...This checks if output is a TTY, and applies colorization as needed.
Strangely, the new code is still showing 100% test coverage. There must be something calling this branch without asserting. Perhaps there's coverage markers that need to be added?