Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add group off_state option #12868

Merged
merged 1 commit into from
Jun 18, 2022
Merged

Add group off_state option #12868

merged 1 commit into from
Jun 18, 2022

Conversation

Koenkk
Copy link
Owner

@Koenkk Koenkk commented Jun 18, 2022

Rationale: while the current group state OFF behaviour sounds ideal (group state is only OFF when all members in it are OFF) it is not always practical. I see at least two possible cases where this doesn't work well:

  • Given that you have e.g. 5 lights in the group controlled by 1 remote, when the remote turns off the lights; all light OFF report have to be received by the coordinator. If one of the messages is dropped (e.g. due to interference) the coordinator considers the group on. In my use case when using the flux integration, flux will turn the group on again (by changing the color temperature) since it still thinks the group is on.
  • If one of the devices in the group doesn't support state reporting (e.g. a Philips Hue bulb) the similar problem as above will occur.

Koenkk added a commit to Koenkk/zigbee2mqtt.io that referenced this pull request Jun 18, 2022
@Koenkk Koenkk merged commit f2e953c into dev Jun 18, 2022
@Koenkk Koenkk deleted the off_state branch June 18, 2022 13:47
@sjorge
Copy link
Sponsor Contributor

sjorge commented Jun 18, 2022

In my use case when using the flux integration, flux will turn the group on again (by changing the color temperature) since it still thinks the group is on.

If your bulbs support it set the color_options.execute_if_off to true, then you can just send the color_temp command and next time you turn them on the bulbs will be the correct color. (Not that this helps the problem you're describing, but it gives a very smooth experience where all my ct lights are the same color temperature depending on ToD even when they just get turned on!)

@Koenkk
Copy link
Owner Author

Koenkk commented Jun 18, 2022

Good tip, thanks!

@jd1900
Copy link
Contributor

jd1900 commented Jul 1, 2022

I don't know if I understand the meaning of this.

Is this replacing the old behavior or adding s new one?

I've found no new option under HA or Z2M interface.

Is it that now when a off is sent to the group instead of waiting all the devices to be off it stores the off value? Or something different?

@Koenkk
Copy link
Owner Author

Koenkk commented Jul 1, 2022

@jd1900 the default behaviour didn't change, group config is not possible via the UI, you can set it in the configuration.yaml..

@jd1900
Copy link
Contributor

jd1900 commented Jul 2, 2022

If your bulbs support it set the color_options.execute_if_off to true

@sjorge How can we configure our lights to change to execute_if_off ?
I've found no documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants