Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale: while the current group state
OFF
behaviour sounds ideal (group state is onlyOFF
when all members in it areOFF
) it is not always practical. I see at least two possible cases where this doesn't work well:OFF
report have to be received by the coordinator. If one of the messages is dropped (e.g. due to interference) the coordinator considers the group on. In my use case when using the flux integration, flux will turn the group on again (by changing the color temperature) since it still thinks the group is on.