Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use relative timestamps in graphviz and plantuml networkmap #3743

Merged
merged 1 commit into from
Jun 14, 2020

Conversation

Kosta-Github
Copy link
Contributor

Use relative timestamps for the network map (e.g, 1 hour, 43 minutes ago or 15 minutes, 10 seconds ago), since that is easier to understand/decode than the standard ISO timestamps.

This introduces an additional (light weight) dependency to humanize-duration which in itself doesn't have any additional dependencies.

Use relative timestamps for the network map (e.g, `1 hour, 43 minutes ago` or `15 minutes, 10 seconds ago`), since that is easier to understand/decode than the standard ISO timestamps.

This introduces an additional (light weight) dependency to [humanize-duration](https://github.com/EvanHahn/HumanizeDuration.js) which in itself doesn't have any additional dependencies.
@Kosta-Github
Copy link
Contributor Author

Kosta-Github commented Jun 14, 2020

Note, that the test failures are not because of this change: they already exist on the dev branch introduced by this commit: c9aa8b2

@Koenkk Koenkk changed the title use relative timestamps Use relative timestamps in graphviz and plantuml networkmap Jun 14, 2020
@Koenkk
Copy link
Owner

Koenkk commented Jun 14, 2020

Thanks again! 🏅

@Koenkk Koenkk merged commit b42c61d into Koenkk:dev Jun 14, 2020
@Kosta-Github Kosta-Github deleted the human-duration branch June 14, 2020 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants