feat(kmd): reduce KMD AUR from 5% to 0.01% starting at nS7HardforkHeight #1841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shamardy
changed the title
onur-ozkan
previously approved these changes
May 27, 2023
This can be shipped now. The new AUR of 0,01% is applied to new utxos/transactions starting from nS7HardforkHeight and not old ones according to this comment KomodoPlatform/komodo#584 (review) Related code excerpt in mm2 |
caglaryucekaya
previously approved these changes
May 29, 2023
caglaryucekaya
approved these changes
May 29, 2023
DeckerSU
reviewed
May 30, 2023
| minutes -= 59; | ||
| let accrued = (value / 10_512_000) * minutes; | ||
| let mut accrued = (value as f64 * AUR_PER_MINUTE) as u64 * minutes; |
There was a problem hiding this comment.
Just curious to know, what's the purpose of introducing floating point arithmetic here, making a conversion from integer to float and vice versa, using drop_mutability! macros instead of simple:
let accrued = if height >= N_S7_HARDFORK_HEIGHT {
(value / 10_512_000) * minutes / 500
} else {
(value / 10_512_000) * minutes
};
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KMD interest calculation is adjusted to reduce AUR (Active User Rewards) from 5% to 0.01% starting from KMD block height
3484958(Fri Jun 30 2023) according to KIP-0001fixes #1840