Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reduce AUR 5% -> 0.01% after nS7HardforkHeight #584

Merged
merged 7 commits into from
May 30, 2023
Merged

reduce AUR 5% -> 0.01% after nS7HardforkHeight #584

merged 7 commits into from
May 30, 2023

Conversation

DeckerSU
Copy link

Don't merge until nS7HardforkHeight will be determined. Then we will need an additional commit to change 7113400 to nS7HardforkHeight in sources.

Changes are needed in the following places:

@dimxy
Copy link
Collaborator

dimxy commented Apr 25, 2023

checked the math, looks good

@DeckerSU DeckerSU mentioned this pull request May 25, 2023
Merged
@DeckerSU DeckerSU requested a review from dimxy May 25, 2023 15:42
@DeckerSU
Copy link
Author

The branch was rebased on s7-pubkeys branch, to be merged right after #585 .

@dimxy
Copy link
Collaborator

dimxy commented May 25, 2023

Where is the formal KIP0001 published? I could not find a link to it on the komodo website or by googling. Maybe we need a link somewhere in the docs @smk762

@DeckerSU
Copy link
Author

Where is the formal KIP0001 published? I could not find a link to it on the komodo website or by googling. Maybe we need a link somewhere in the docs @smk762

This commit contains link on it in commit message - https://github.com/KomodoPlatform/kips/blob/main/kip-0001.mediawiki .

Also we have results for KIP0001 voting here.

dimxy
dimxy previously approved these changes May 26, 2023
View reviewed changes
Copy link
Collaborator

@dimxy dimxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like in the KIP0001 the condition for the new AUR is not specified strictly:
it could be that we must apply the new AUR of 0,01% to utxos that are newer than nS7HardforkHeight,
or another way we must begin to apply the new AUR immediately after the chain tip has reached nS7HardforkHeight to any utxo (including those created before nS7HardforkHeight).
So we decided on the 1st option. If yes then it is LGTM

@tonymorony tonymorony mentioned this pull request May 26, 2023
Closed
@DeckerSU DeckerSU requested a review from ca333 May 27, 2023 10:18
@shamardy shamardy mentioned this pull request May 29, 2023
Merged
@ca333
Copy link

ca333 commented May 29, 2023

The branch was rebased on s7-pubkeys branch, to be merged right after #585 .

s7-pubkeys branch was updated - plz check @DeckerSU

@DeckerSU
Copy link
Author

Merged s7-pubkeys changes, i.e. new ca333_EU key.

@DeckerSU DeckerSU requested a review from dimxy May 29, 2023 19:59
@ca333 ca333 merged commit ac466df into KomodoPlatform:dev May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ca333 ca333 ca333 approved these changes

@dimxy dimxy Awaiting requested review from dimxy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DeckerSU @dimxy @ca333 @smk762