chore(mm2_main): replace lib.rs by mm2.rs as the root lib #2178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of lib.rs. Seems like lib.rs isn't that popular and mm2 favored. Having lib.rs there forced us to write #[path = 'file/path.rs'] directive for every module we define, even the trivial ones that didn't need no #[path]. This commit fixes this by setting mm2.rs as the root lib for mm2_main.
shamardy
changed the title
mariocynicys
added
under review
and removed
in progress
mariocynicys
changed the title
onur-ozkan
previously approved these changes
Aug 7, 2024
mariocynicys
commented
Aug 7, 2024
mariocynicys
dismissed stale reviews from onur-ozkan and borngraced
via
8c3331c
mariocynicys
commented
Aug 8, 2024
Alrighttt
pushed a commit
that referenced
this pull request
Aug 9, 2024
Having lib.rs forced us to write #[path = 'file/path.rs'] directive for every module we define, even the trivial ones that didn't need no #[path]. This commit fixes this by setting mm2.rs as the root lib for mm2_main.
dimxy
added a commit
to dimxy/komodo-defi-framework
that referenced
this pull request
Aug 12, 2024
* dev: chore(mm2_main): replace lib.rs by mm2.rs as the root lib (KomodoPlatform#2178)
dimxy
added a commit
that referenced
this pull request
Aug 15, 2024
* dev: chore(mm2_main): replace lib.rs by mm2.rs as the root lib (#2178) chore(release): bump mm2 version to 2.2.0-beta (#2188) ci(docker-tests): ignore tendermint IBC tests for now (#2185) feat(nft-swap): complete refund methods (#2129) chore(release): add changelog entries for v2.1.0-beta (#2165) fix(zcoin): don't force low r signing to generate htlc pubkey for zcoin (#2184) chore(rust-analyzer): add rust-analyzer into the workspace toolchain (#2179) chore: migrate .cargo/config to .cargo/config.toml to avoid deprecation warning (#2177) fix(swaps): ensure taker payment spend confirmations (#2176)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like lib.rs isn't that popular and mm2 is favored.
Having lib.rs there forced us to write #[path = 'file/path.rs'] directive for every module we define, even the trivial ones that didn't need no #[path].
This commit fixes this by setting mm2.rs as the root lib for mm2_main.
To Test: No QA testing needed for this PR.