-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional filters support in my_recent_swaps #784. #796
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are only questions and suggestions. Could you please answer them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve this :)
@tonymorony Can you give it a test, please? 🙂 New params are documented in this PR: https://github.com/KomodoPlatform/developer-docs/pull/235/files |
my observations so far: https://gist.github.com/tonymorony/3c7a996a1be5c3b925f387d4bc30f6f6 was not able to use timestamp filter - probably I'm doing something wrong? |
The I will set the default |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks!
when page_number and from_uuid are not set in request.
35cb867
thanks! it might be worth reflecting |
Done: KomodoPlatform/developer-docs@3cd848f Thank you @sergeyboyko0791 for the review and @tonymorony for testing! I merge this PR now 🙂 |
Achieved by using SQLite database - swaps JSON data are indexed into it. The matching uuids are selected on the my_recent_swaps request, swaps data is read from JSON files and then returned as a response.