Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update/nft methods #317

Open
wants to merge 40 commits into
base: dev
Choose a base branch
from
Open

Update/nft methods #317

wants to merge 40 commits into from

Conversation

smk762
Copy link
Contributor

@smk762 smk762 commented Aug 23, 2024

Continues from #270

harsenyan3 and others added 15 commits July 5, 2024 11:36
@harsenyan3
Update index.mdx
980458d
@harsenyan3
Update index.mdx
34924cf 
Indicated proxy_auth is optional and defaults to false.
@harsenyan3
Update index.mdx
7137071 
Readded BSC chain
@harsenyan3
Update index.mdx
390a850
@harsenyan3
Update index.mdx
37fa294
@harsenyan3
Update index.mdx
eafec11
@harsenyan3
Update index.mdx
7b8d674
@harsenyan3
Update index.mdx
65ee467 
fixed nft_req
@harsenyan3
Create index.mdx
ebaad1b 
Created enable_nft file (based on enable_erc20)
@harsenyan3
Merge branch 'dev' into dev
36b22f2
@harsenyan3
Update index.mdx
689cc92 
Added NftProvider object to common structures
@harsenyan3
Update index.mdx
6e825b8 
Changed activation_param definition to be a standard NftProvider object
@harsenyan3
Update index.mdx
56025b5
@harsenyan3
Update index.mdx
6e131c5
@smk762
Merge pull request #270 from harsenyan3/dev
394bc21 
NFT RPC Methods Docs update
@smk762 smk762 marked this pull request as draft August 23, 2024 04:52
@smk762 smk762 self-assigned this Aug 23, 2024
@smk762 smk762 changed the base branch from main to dev August 23, 2024 04:53
laruh
laruh requested changes Aug 25, 2024
View reviewed changes
Copy link
Member

@laruh laruh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates, 1st review iteration

src/pages/komodo-defi-framework/api/v20/enable_eth_with_tokens/index.mdx Outdated Show resolved Hide resolved
src/pages/komodo-defi-framework/api/v20-dev/non_fungible_tokens/update_nft/index.mdx Outdated Show resolved Hide resolved
src/pages/komodo-defi-framework/api/v20-dev/non_fungible_tokens/update_nft/index.mdx Outdated Show resolved Hide resolved
src/pages/komodo-defi-framework/api/v20-dev/non_fungible_tokens/enable_nft/index.mdx Outdated Show resolved Hide resolved
src/pages/komodo-defi-framework/api/v20-dev/non_fungible_tokens/enable_nft/index.mdx Outdated Show resolved Hide resolved
src/pages/komodo-defi-framework/api/common_structures/nfts/index.mdx Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Preview for merge commit: 3c6541f, available on cloudflare at: https://c3b10cf0.komodo-docs.pages.dev/en/docs/

@smk762
[Bot] File and author data updated, validated and updated internal li…
f5f31df 
…nks, formatted md content, checked presence of file and dirs based on sidebar, checked presence of h1 in every file, update Komodo DeFi Framework methods table, adds/updates preview images when base is main
laruh
laruh requested changes Sep 17, 2024
View reviewed changes
Copy link
Member

@laruh laruh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes!
I have one note

src/pages/komodo-defi-framework/api/common_structures/activation/index.mdx Outdated
| maker\_swap\_v2\_contract | string | Address for the maker's new V2 swap smart contract. Must be provided if "use\_trading\_proto\_v2"is true in mm2 configuration |
| taker\_swap\_v2\_contract | string | Address for the taker's new V2 swap smart contract. Must be provided if "use\_trading\_proto\_v2"is true in mm2 configuration |
| nft\_maker\_swap\_v2\_contract | string | Address for the maker's new V2 NFT swap smart contract. Must be provided if "use\_trading\_proto\_v2"is true in mm2 configuration |
| nft\_taker\_swap\_v2\_contract | string | Address for the taker's new V2 NFT swap smart contract. Must be provided if "use\_trading\_proto\_v2"is true in mm2 configuration |
Copy link
Member

@laruh laruh Sep 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we dont have nft taker smart contact field in Komodo DeFi project and such solidity contract in Etomic Swap project.

Right now we are focusing on Nft maker swap operations, where Maker is Nft owner.

Copy link
Member

@laruh laruh Nov 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, also please clarify that its an Optional object in activation request. Default is none

komodo-docs-mdx/src/pages/komodo-defi-framework/api/v20/enable_eth_with_tokens/index.mdx

Line 17 in 33036fd

| swap\_v2\_contracts | object | Must be provided if "use\_trading\_proto\_v2" is true in [your configuration](/komodo-defi-framework/setup/configure-mm2-json/). A standard [SwapV2Contracts](/komodo-defi-framework/api/common_structures/activation/#tokens-request) object. |

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in ec9dad6

src/pages/komodo-defi-framework/api/common_structures/activation/index.mdx Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Preview for merge commit: 756ce49, available on cloudflare at: https://b4082fd1.komodo-docs.pages.dev/en/docs/

@smk762 smk762 requested a review from laruh October 30, 2024 17:28
@github-actions GitHub Actions
Copy link

Preview for merge commit: b44f4e0, available on cloudflare at: https://303ec334.komodo-docs.pages.dev/en/docs/

@github-actions GitHub Actions
Copy link

Preview for merge commit: 9a20ff4, available on cloudflare at: https://4c8594ea.komodo-docs.pages.dev/en/docs/

smk762 and others added 2 commits October 30, 2024 18:28
@smk762
[Bot] File and author data updated, validated and updated internal li…
517c793 
…nks, formatted md content, checked presence of file and dirs based on sidebar, checked presence of h1 in every file, update Komodo DeFi Framework methods table, adds/updates preview images when base is main
@gcharang
Merge pull request #365 from KomodoPlatform/lint-fix-patches/update/n…
2262176 
…ft-methods
@smk762 smk762 added the P1 Important task which needs to be completed soon label Nov 1, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2024

Preview for merge commit: 787cc7b, available on cloudflare at: https://0d484ee9.komodo-docs.pages.dev/en/docs/

@shamardy
Copy link

shamardy commented Nov 8, 2024

@laruh can you please check if your comments have been resolved and if you have any more comments?

@smk762 smk762 mentioned this pull request Nov 11, 2024
Open
laruh
laruh requested changes Nov 12, 2024
View reviewed changes
Copy link
Member

@laruh laruh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, for the fixes, here my last notes and one note is left above

src/pages/komodo-defi-framework/api/v20/enable_eth_with_tokens/index.mdx Outdated
Comment on lines 293 to 294
"eth_addresses_infos": {
"0xab95…6498": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Such eth address display was fixed KomodoPlatform/komodo-defi-framework#2254
Now response shows show full eth address format

please also fix it in other eth with tokens activation response examples

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in ec9dad6

src/pages/komodo-defi-framework/api/v20/enable_eth_with_tokens/index.mdx Outdated
Comment on lines 301 to 302
"erc20_addresses_infos": {
"0xab95…6498": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as comment above

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in ec9dad6

@smk762 smk762 requested a review from laruh November 14, 2024 07:38
@github-actions GitHub Actions
Copy link

Preview for merge commit: 99d9f4b, available on cloudflare at: https://9333fdb9.komodo-docs.pages.dev/en/docs/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShantanuSharma9873 ShantanuSharma9873 ShantanuSharma9873 approved these changes

@AndrewDelaney AndrewDelaney AndrewDelaney approved these changes

@gcharang gcharang Awaiting requested review from gcharang

@laruh laruh Awaiting requested review from laruh

Assignees

@smk762 smk762

Labels
awaiting review KDF methods P1 Important task which needs to be completed soon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@smk762 @shamardy @AndrewDelaney @laruh @ShantanuSharma9873 @harsenyan3 @gcharang