Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update rpc_mode default value #328

Open
wants to merge 7 commits into
base: dev
Choose a base branch
from
Open

update rpc_mode default value #328

wants to merge 7 commits into from

Conversation

smk762
Copy link
Contributor

@smk762 smk762 commented Sep 13, 2024

closes #265

@smk762
Copy link
Contributor Author

smk762 commented Sep 13, 2024

@shamardy which activation methods accept this param? I will apply updates to postman collection.

Copy link

Preview for merge commit: 30134a9, available on cloudflare at: https://b2ec1eeb.komodo-docs.pages.dev/en/docs/

Copy link

Preview for merge commit: 888f9ab, available on cloudflare at: https://c47de080.komodo-docs.pages.dev/en/docs/

…nks, formatted md content, checked presence of file and dirs based on sidebar, checked presence of h1 in every file, update Komodo DeFi Framework methods table, adds/updates preview images when base is main
@shamardy
Copy link

which activation methods accept this param? I will apply updates to postman collection.

enable_eth_with_tokens method only

Copy link

Preview for merge commit: ae5b187, available on cloudflare at: https://51b9f6a0.komodo-docs.pages.dev/en/docs/

@@ -67,7 +67,6 @@ Additionally, it supports ERC20 tokens on the ETH chain and associated ERC20 lik
"gui_auth": true
}
],
"rpc_mode": "Http",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section is the "Request including optional gas station parameters" section. Should we not still display the optional parameter with its value set to 'default' instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As it defaults to Default, seems a waste to define what's defined by default. Might be better to add an example with the non-default value.

Copy link

github-actions bot commented Nov 9, 2024

Preview for merge commit: 2e0c933, available on cloudflare at: https://31693d28.komodo-docs.pages.dev/en/docs/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants