Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST]: Release visual blockers #1427

Closed
8 of 9 tasks
tonymorony opened this issue Nov 15, 2021 · 4 comments · Fixed by #1418
Closed
8 of 9 tasks

[FEATURE REQUEST]: Release visual blockers #1427

tonymorony opened this issue Nov 15, 2021 · 4 comments · Fixed by #1418
Assignees
Labels
P0 Blocker / critical defect

Comments

@tonymorony
Copy link

tonymorony commented Nov 15, 2021

this issue cf: #1383 (might be duplicates also)

Login part

  • Welcome screen is visually broken now in light theme, there shouldn't be a grey color

image

figma:

image

  • 2) Login screen is visually broken now in light theme, there shouldn't be a grey color:

image

figma:

image

  • 3) Seed import screen is visually broken now in light theme, there shouldn't be a grey color

image

figma:

image

  • 4) Custom seed popup is visually broken now in light theme

image

figma:

image

  • 5) New wallet creation process is visually broken now in light theme

image

figma:

image

  • 6) words confirmation - same

image

image

  • 7) wallet deletion modal:

image

  • 8) Green color on text selection and spinner spoil a bit overall impression - it should follow the main theme color

Screenshot 2021-11-26 at 06 18 43

Screenshot 2021-11-26 at 06 18 21

  • 9) Now nothing happens if the user inputs not correct password and presses "Connect"
@tonymorony tonymorony assigned ghost and tonymorony Nov 15, 2021
@tonymorony
Copy link
Author

tonymorony commented Nov 15, 2021

Dashboard/wallet part

  • 1) Notifications in light theme

image

figma:

image

  • 2) Logout modal

image

  • 3) Light/dark theme mode switching button is missing

  • 4) Price graph is missing in coin details view

  • 5) Fiat icon is confusing - there is no "Coming soon" if the menu is minified and it has the same color as others

Screen.Recording.2021-11-15.at.16.26.59.mov
  • 6) these icons should be improved (please contact Alex if needed). Also received reports that it displaying broken on windows, would be great to check

Screenshot 2021-11-17 at 20 46 41

Screenshot 2021-11-17 at 20 49 00

  • 7) copy icons aren't visible on seed revealing screen in light theme

Screenshot 2021-11-18 at 01 10 49

  • 8) tx nodes field is grey

Screenshot 2021-11-21 at 00 28 30

  • 9) font is not readable

image

  • 10) there is no such line in figma design, it looks not good imo

Screenshot 2021-11-27 at 23 38 55

will add more items here

@tonymorony
Copy link
Author

tonymorony commented Nov 15, 2021

Trading (simple view)

  • 1) Swap now button is visually broken

Screenshot 2021-11-15 at 16 11 28

figma:

Screenshot 2021-11-15 at 16 13 50

  • 2) Swap filters are visually broken

image

figma:

image

  • 3) Swap cards are visually broken (especially on selection)

Screenshot 2021-11-15 at 16 16 14

figma:

image

  • 4) Swap card is not updated accordingly to figma

image

figma:

image

  • 5) colours looks visually broken (coin icons are not visible, search icon isn't visible)

image

figma:

probably we'll need @poleving help for this one since not found relevant content in figma

  • 6) It would be awesome to make Simple / Pro switcher not dancing (on the same position in both pro and simple views)
Screen.Recording.2021-11-20.at.13.17.24.mov

@tonymorony
Copy link
Author

tonymorony commented Nov 15, 2021

Pro view

  • 1) Not writing about the overall mismatch with designs since we have not worked on this part much yet, want just to highlight one p0 to not miss - after order select price field content is not visible

Screenshot 2021-11-15 at 16 24 02

  • 2) Selectors are grey in dark mode

Screenshot 2021-11-20 at 13 11 16

  • 3) A bit annoying thing - recently it started to take two lines :)

Screenshot 2021-11-20 at 17 43 36

  • 4) time permissive

Screenshot 2021-11-30 at 05 51 09

@smk762
Copy link
Collaborator

smk762 commented Dec 6, 2021

  1. colours looks visually broken (coin icons are not visible, search icon isn't visible)

Search now visible, icons still very faded where not enables. maybe could reduce transparency?

  1. It would be awesome to make Simple / Pro switcher not dancing (on the same position in both pro and simple views)

Fixed in #1479

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0 Blocker / critical defect
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants