Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design tweaks #1418

Merged
merged 137 commits into from
Dec 7, 2021
Merged

Design tweaks #1418

merged 137 commits into from
Dec 7, 2021

Conversation

ghost
Copy link

@ghost ghost commented Nov 10, 2021

closes: #1461
closes: #1453
closes: #1427
closes: #1431

This pr changes/affects:

  • ComboBox style
  • Sidebar behaviour on hover line icon
  • Sidebar behaviour in shrunk mode: hovering makes it to expand
  • Pro view design
  • Startup screen design

@tonymorony
Copy link

tonymorony commented Nov 12, 2021

That's a cool idea with menu moving @SylEze ! I think we might try to hide the menu similar way not only for dex but for all sections.

sometimes it bugging on my side tho (check 00:30) :

Screen.Recording.2021-11-13.at.00.38.05.mov

@smk762
Copy link
Collaborator

smk762 commented Nov 13, 2021

Thanks for fixing text overflow on expand with fade in and removing fiat tooltip. I can replicate the icon overflow also
image
Possible to only display full icon when in fully expanded state?

@smk762
Copy link
Collaborator

smk762 commented Nov 15, 2021

Overflow issue appears fixed here. There is a small quirk, looks like there is tiny text sometimes, otherwise ok

sidebar-expand-text.mp4

@Milerius
Copy link

Milerius commented Dec 4, 2021

Capture d’écran 2021-12-04 à 05 45 12

NaN values for min_orders

Capture d’écran 2021-12-04 à 05 46 49

The list doesn't fit with the rounded design; looks not natural.

In comparaison the sub list of filtering looks more natural:

Capture d’écran 2021-12-04 à 05 47 56

In the following video, the cursor changes only on the first button, but not on the second one:

Enregistrement.de.l.ecran.2021-12-04.a.05.52.33.mov

Room for improvements, in the following screenshot having a search bar, would be nice, also note that the number of default wallets shown in the list is 3. There is enough place to have more, even in full screen:

Capture d’écran 2021-12-04 à 05 53 52

Capture d’écran 2021-12-04 à 05 55 51

Not a fan of the word connect here, also missing one uppercase at the beginning of the word IMHO:

Capture d’écran 2021-12-04 à 05 56 54

I've shared a new icon package logo for lang on keybase, and it's not used in settings or login page, making it very ugly on settings. Also, there is a lack of over effect, and it look a bit unnatural:

Enregistrement.de.l.ecran.2021-12-04.a.06.00.51.mov

@tonymorony
Copy link

thank you for the feedback @Milerius, created an issue #1475 so we'll consider it in the future iterations

@SylEze @smk762 could you please have a look at the NaN values for the min_orders problem?

@smk762
Copy link
Collaborator

smk762 commented Dec 4, 2021

NaN values for min_orders

Seems to be only where coin has no previous transactions, and a coin without history has not previously been selected for side of pair.

nan.mp4

@ghost
Copy link
Author

ghost commented Dec 4, 2021

thank you for the feedback @Milerius, created an issue #1475 so we'll consider it in the future iterations

@SylEze @smk762 could you please have a look at the NaN values for the min_orders problem?

I know where the bug is, let me few minutes

@smk762
Copy link
Collaborator

smk762 commented Dec 6, 2021

I seem to be having a problem deleting wallets now. Sometimes it works, not sure why and logs are no help.

no_del_pass.mp4

checked on latest dev, no problem.

Generated seed in dark mode (and binance dark mode) warning text background makes text unreadable
image

Copy link
Collaborator

@smk762 smk762 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

built locally to test on all OS. Basic launch and trade ok. Outstanding visual tweaks moved to #1485

@Milerius
Copy link

Milerius commented Dec 7, 2021

Thanks for the big pr @ssakone @smk762 @tonymorony @SylEze

@Milerius Milerius merged commit 9f98caa into dev Dec 7, 2021
@Milerius Milerius deleted the design_tweaks branch December 7, 2021 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants