Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Wallet login validation has extraneous text #1431

Closed
smk762 opened this issue Nov 16, 2021 · 3 comments · Fixed by #1418
Closed

[BUG]: Wallet login validation has extraneous text #1431

smk762 opened this issue Nov 16, 2021 · 3 comments · Fixed by #1418
Assignees
Labels
bug Something isn't working P1 Major issue needs to be fixed

Comments

@smk762
Copy link
Collaborator

smk762 commented Nov 16, 2021

Describe the bug
When entering incorrect password, the validation error messages include items only required for initial wallet password creation.

To Reproduce
Steps to reproduce the behavior:

  1. Load app
  2. Select a wallet to login
  3. Enter incorrect password
  4. See extraneous validation error messages

Expected behavior
A single error message should be shown in red: incorrect password

Screenshots
image

@smk762 smk762 added the bug Something isn't working label Nov 16, 2021
@smk762 smk762 assigned Milerius, tonymorony and ghost Nov 16, 2021
@tonymorony
Copy link

I'm not able to reproduce this one on the latest dev - there is no indication when I input not correct password and press connect (which is also a bug)
@smk762 Could you please clarify on which commit this problem is actual?

On the latest release (0.5.3) it seems to work correctly - icon and field became red on not correct password login try

@tonymorony tonymorony added P1 Major issue needs to be fixed need more info labels Nov 17, 2021
@smk762
Copy link
Collaborator Author

smk762 commented Nov 17, 2021

I get same on latest dev: button disabled until all criteria (length, capital, special chat) is met.
Same for latest design_tweaks and fix_suffix_form builds.

None of the above show any visual feedback on bad password (different bug) like the red outline / shake effect seen in last release.

I'll keep an eye out and see if I can catch this one again, but current state seems to be unaffected.

@tonymorony
Copy link

thank you for the clarification 👍

I think we should return back red outline/shake effect and in parallel, it can be checked if there is a place in code that can produce pb as on your screenshot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P1 Major issue needs to be fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants