Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: app fetches tx_history of last coin in wallet even when on portfolio page #1999

Closed
cipig opened this issue Oct 7, 2022 · 1 comment
Closed

[BUG]: app fetches tx_history of last coin in wallet even when on portfolio page #1999

cipig opened this issue Oct 7, 2022 · 1 comment
Assignees
@smk762
Labels
bug Something isn't working next iteration to not forget to include it P1 Major issue needs to be fixed

Comments

@cipig
Copy link
Member

cipig commented Oct 7, 2022

  • go to wallet of a EVM token
  • switch to portfolio page
  • the app continues to fetch tx_history of last accessed token every 30s like this
[13:53:59] [debug] [mm2.service.cpp:1904] [4131088]: Process transactions of ticker: PGX-PLG20
[13:53:59] [info] [mm2.service.cpp:1975] [4131088]: url scan: /api/v2/plg_tx_history/0xc1c93D475dc82Fe72DBC7074d55f5a734F8cEEAE/0x15C577f4b9fbe66735A9bFF9B0B5D3EA2854Bfaa
[13:53:59] [info] [mm2.cpp:679] [4131088]: Processing rpc call: tx_history, url: /api/v2/plg_tx_history/0xc1c93D475dc82Fe72DBC7074d55f5a734F8cEEAE/0x15C577f4b9fbe66735A9bFF9B0B5D3EA2854Bfaa, endpoint: https://komodo.live:3334/

additionally this tx_history request blocks the app for 1-3s, no other operations possible during that time, sometimes even mouse stops moving

can we please stop updating tx_history when user is not on wallet page?
@cipig cipig added the bug Something isn't working label Oct 7, 2022
@ghost ghost self-assigned this Oct 9, 2022
@smk762 smk762 mentioned this issue Oct 12, 2022
Closed
@tonymorony tonymorony added the P1 Major issue needs to be fixed label Nov 27, 2022
@smk762 smk762 added P0 Blocker / critical defect and removed P1 Major issue needs to be fixed labels Jun 7, 2023
@smk762 smk762 self-assigned this Jun 7, 2023
@smk762 smk762 added P1 Major issue needs to be fixed next iteration to not forget to include it and removed P0 Blocker / critical defect 0.5.8 labels Jun 11, 2023
@smk762
Copy link
Collaborator

smk762 commented Jun 11, 2023

I tried a simple implementation for this, but it seemed to introduce potential crashes. Pushed to next iteration to allow for a more robust solution.

@ca333 ca333 closed this as completed Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smk762 smk762

Labels
bug Something isn't working next iteration to not forget to include it P1 Major issue needs to be fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ca333 @tonymorony @cipig @smk762