-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FR]: Review / refactor update loop #2002
Comments
i had 3 crashes in the last 2h or so... here is the last one:
|
here is another one, from earlier today:
they all happen after |
@SylEze these crashes doesn't looks good at all, please pause all current non-critical refactoring and switch exclusively to this problem until app stops crashing |
sometimes it also happens that app looses connection to mm2, it shows no orderbook any more and no other operations involving mm2 work... app still runs, shows prices and stuff... and mm2 also still runs and finishes running swaps without problem... but the entire communication between app and mm2 is gone... no errors in either app or mm2 log |
not sure if related, but i had a crash after clicking on buy to place an order/start a swap
|
@cipig can you pls try running app, then doing |
will try after swaps finish |
ok - that's expected behaviour, tho it could be improved (like returning to login screen after "x" time) |
And please can someone who succeeds in making the application crash can test at this commit 🙏 ? (it's before tx history rework and slp tokens merge) |
Cipi's OS is Debian 11 To test:
|
This time i had the app running for > 24h without problems, but in the end it crashed. The log:
looks like it's more related to the i had one swap running at the time of the crash, but the app was not active, not in foreground... i was surfing the internet when i saw the app disappearing from task bar. After i restarted the app the swap finished right away. |
i just had the case where the app stalled, can't do anything, need to kill it
see the |
closing as stale |
There have been some reports of app crash at the heavier levels of use (lots of coins selected, lots of orders). To make things a bit smoother, we should be a bit more selective with what we are updating, and spread it out a bit so there isnt a large burst or update requests each cycle.
Examples:
Maybe a good starting point is a diagram to visualise the event loop so we can further optimise it by prioritising items and refresh frequency categories (we already do this a little, but can expand it).
In some places, there is a suboptimal delay getting info which impacts UX, like when you see orderbook say you dont have enough funds for a second until it refreshes balance.
The text was updated successfully, but these errors were encountered: