Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Trade confirmation tickers not same as selected in order #2105

Closed
TheComputerGenie opened this issue Nov 23, 2022 · 10 comments · Fixed by #2134
Closed

[BUG] Trade confirmation tickers not same as selected in order #2105

TheComputerGenie opened this issue Nov 23, 2022 · 10 comments · Fixed by #2134
Labels
bug Something isn't working P0 Blocker / critical defect

Comments

@TheComputerGenie
Copy link

image
Parts of it say KMD/Komodo and none of it should when making a TKL/ARRR trade

@TheComputerGenie TheComputerGenie added the bug Something isn't working label Nov 23, 2022
@ghost ghost added the P1 Major issue needs to be fixed label Nov 23, 2022
@smk762
Copy link
Collaborator

smk762 commented Nov 24, 2022

Can you pls attach logs or replication steps

@TheComputerGenie
Copy link
Author

or replication steps

Click "DEX" tab in left-hand menu
Set left coin to ARRR
Set right coin to TKL
Click "Buy ARRR"
Set Price
Set Volume
Click "START SWAP"

"Confirm Exchange Details" shows KMD as coin instead of ARRR
"Confirm Exchange Details" shows KMD as fee coin also

@TheComputerGenie
Copy link
Author

As for logs, I wouldn't know where to look to find a non-placed order in the logs. Since it throws KMD in there on its own, I'm not about to click "Confirm" and just hope it's a GUI visualization error and I'm not somehow spending both TKL and KMD to get KMD and not the ARRR I'm after.

@smk762
Copy link
Collaborator

smk762 commented Nov 24, 2022

I cant replicate here. Is it happening consistently? Is it just after login or other actions prior (e.g. on wallet page for specific coin before clicking dex tab; coins are being enabled etc).
Try an assets reset too. Not sure why it would make a difference, but cant hurt to rule it out.

@smk762 smk762 changed the title v0.5.7 doesn't know what I want [BUG] Trade confirmation tickers not same as selected in order Nov 25, 2022
@smk762
Copy link
Collaborator

smk762 commented Nov 25, 2022

Related report from Discord - KMD on both sides

image

This came from ARRR on left combo and KMD on right combo in sell mode, selecting from orderbook.
When KMD on left and ARR on right, user did not have problem.

@SylEze can you think of any potential cause or race condition etc which might result in this?

@tonymorony tonymorony added P0 Blocker / critical defect 0.5.8 and removed P1 Major issue needs to be fixed labels Nov 25, 2022
@ghost ghost self-assigned this Nov 30, 2022
@smk762
Copy link
Collaborator

smk762 commented Nov 30, 2022

@Canialon @SirSevenG A discord user provided video which showed steps to replicate in 0.5.7 release or ticker_bug branch, though so far I have still not been able to.

Please try the following on both the 0.5.7 release and on the ticker_bug & fix/trade-conf-modal-ticker-same branches:

  • Login
  • go to dex page
  • change right ticker
  • flip combo boxes with the button between them
  • select a red order from the orderbook (buy order)
  • click "start swap"
  • see tickers incorrect in confirmation window

Additional context:

  • user was not busy enabling coins when it happened
  • 11 coins were enabled, and wallet page was sorted by balance.
  • "Show only coins with balance" filter was not applied.
  • 3 of the 11 coins had a balance. KMD had highest balance (and was the duplicated ticker). The other two coins with balance were USDT-BEP20 & TKL.
  • The remaining coins without balance were BNB, some BEP20 tokens BTC and LTC.

Ping me in chat if you want a copy of the video to refer to.

If you are able to replicate this, take a screenshot, share logs in chat, and start the swap so we can confirm this is just a visual glitch.

@ghost
Copy link

ghost commented Nov 30, 2022

image Parts of it say KMD/Komodo and none of it should when making a TKL/ARRR trade

I really think it's a frontend issue as I mentionned here: #2134 (comment), where I explain why

I managed to reproduce and after confirming the swap everything was good

Please if you can reproduce with test coins try to confirm the swap and give me your feedback

@SirSevenG
Copy link

Couldn't reproduce so far a single time.

@ghost ghost closed this as completed in #2134 Dec 6, 2022
@ghost
Copy link

ghost commented Dec 6, 2022

Hey @TheComputerGenie, if you have time can you test our possible recent fix please ?
#2134

@ghost ghost reopened this Dec 6, 2022
@smk762
Copy link
Collaborator

smk762 commented Dec 9, 2022

The other Discord use who reported this has tested new branch and been unable to replicate

@smk762 smk762 closed this as completed Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P0 Blocker / critical defect
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants