Fix trade confirm modal ticker icons wrong #2134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
accordingly to the reports the problem is not just in icon but actually wrong tickers passing (#2105 (comment) there is an marketmaker error that Base/Rel tickers can't be the same in this case) Was you able to reproduce the issue on your side @SylEze ? |
The only issue was the icons on my side |
|
conflicts need to be resolved ^ |
ghost
mentioned this pull request
smk762
approved these changes
Dec 6, 2022
SirSevenG
approved these changes
Dec 6, 2022
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Might fix #2105, hard to replicate, waiting for more feedbacks!