-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wallet enabling rework #1232
Wallet enabling rework #1232
Conversation
* Log is_during_enabling variable mm2_service::batch_balance_and_tx
* Status is "enabling_coins"
You can start checking @smk762 i suggest:
If you have any suggestion on the behaviour meanwhile coins are getting "enabled" please feel free. One of my suggestion would be to split into more batches if more than 5 coins are enabled at the same time or on starting. What do you think @tonymorony ? This way if one coin cause the whole batch to not be answered we can have more batch we can also do a batch less solution, and enable one by one |
|
…ktop into wallet_enabling_rework
Detected various frontend issues:
|
* Reset model filter when leaving the dashboard
…let_enabling_rework
I found the reason of the slowing bug when enabling lot of coins, it's due too:
This property make Qt dynamically recalculate the whole sorting/filtering each time a bunch of coins are added, and this actions can be slow if repeated too often. Few ideas how to solve that:
can you take care of that @SylEze ? With property to true: Enregistrement.de.l.ecran.2021-09-01.a.11.36.33.movWith property to false (no filtering - no sort): Enregistrement.de.l.ecran.2021-09-01.a.11.38.13.mov |
Balance from enable works great, seen as soon as added to list. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's resolving the problem of indefinitely hang of app startup with a lot of assets
however, there are two more problems which we need to resolve @SylEze @Milerius :
- if you start the app with 100-200 assets app became unresponsive/hangs for 30 seconds or so
- when there are a lot of assets there is a loading spinner on tabs switching to the dashboard
Will close #1212 when ready.
It's in a draft stage for the moment.