Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add PRivaCY Coin (PRCY) #1549

Merged
merged 1 commit into from
Jan 16, 2022
Merged

add PRivaCY Coin (PRCY) #1549

merged 1 commit into from
Jan 16, 2022

Conversation

lyricidal
Copy link

@lyricidal lyricidal changed the title add PRCY add PRivaCY Coin (PRCY) Jan 6, 2022
@tonymorony
Copy link

thank you for the pull request opening @lyricidal

at first assets you add to GUI should be added into coins repo (source of information about assets supported by protocol)
https://github.com/KomodoPlatform/coins#0-the-coin-must-have-participated-in-a-successful-atomic-swap-using-atomicdex-api
GUI uses coins file from this repo so without that your asset will not work.

here is a draft of the documentation on the desktop GUI asset adding process (will be published soon):
https://github.com/KomodoPlatform/developer-docs/blob/smk-dev/docs/basic-docs/atomicdex/atomicdex-desktop/add-coin-to-atomicdex-desktop.md

@lyricidal
Copy link
Author

thank you for the pull request opening @lyricidal

at first assets you add to GUI should be added into coins repo (source of information about assets supported by protocol) https://github.com/KomodoPlatform/coins#0-the-coin-must-have-participated-in-a-successful-atomic-swap-using-atomicdex-api GUI uses coins file from this repo so without that your asset will not work.

here is a draft of the documentation on the desktop GUI asset adding process (will be published soon): https://github.com/KomodoPlatform/developer-docs/blob/smk-dev/docs/basic-docs/atomicdex/atomicdex-desktop/add-coin-to-atomicdex-desktop.md

Thank you for the quick response - I had just stumbled upon that as well and am in the process of sorting that out too. Will link to it when complete.

@lyricidal
Copy link
Author

Submitted PR: KomodoPlatform/coins#429

smk762
smk762 previously approved these changes Jan 12, 2022
Copy link
Collaborator

@smk762 smk762 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Launches and enables as expected

@smk762 smk762 self-requested a review January 16, 2022 10:48
@smk762 smk762 merged commit 8935cd8 into KomodoPlatform:dev Jan 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants