Pirate (ARRR) integration

[smk762]

Closes #1188
Closes #1938

• Enable ZHTLC coins
• Disable ZHTLC coins
• Withdraw ZHTLC coins
• Swap ZHTLC coins
• Update Bestorders to v2 RPC
• Update Orderbook to v2 RPC
• enabling and withdrawing are a 2 part process. at the moment there is a loop while awaiting step one to be ready for step 2 which exits after 50 tries. If error or success, operation will continue, but if operation not "ready" we might have to check on it gain later (e.g. additional loop at step-off frequency) or force cancel the operation.
• Implement transaction history for ZHTLC coins. Uses z_coin_tx_history v2 RPC
• Sending funds with custom fees fails.
• Some overlap for public address / private key in "View seed and private keys"
• Sent funds confirmation shows tx date of 1970
• Sent funds confirmation address and tx hash is being clipped.
• Receive funds address text is clipped
• Fix ZHTLC balance not updating
• Block sending when in mid activation (Use signal to track activation state).
• Block swapping when in mid activation (Use signal to track activation state).
• Show ZHTLC activation percentage on portfolio page.
• Show ZHTLC activation percentage on wallet page.
• Add "activation_status" to global coins config
• Hide tx history explorer link while enabling
• Fix tx history details overflow
• Add address validation error message when not fully activated
• Create modal to download Zcash params

[smk762]

This PR is currently using non-standard mm2 and coins files for testing. This mm2 will not work on Ubuntu 18.04 due to GCLIB version

[smk762]

ZOMBIE and ARRR are marked as "wallet only" but you can remove that manually in local coins.json file to allow for swapping.
ARRR electrums are down at the moment, but I can supply some ZOMBIE (or put up a trade for you) on request for testing.

[smk762]

PoC steps for delayed actions:

• when action initiates, push notification {method} initiated. task id: {task_id}
• when action status changes to "Ready" or "failed", push notification with result
• clicking on notification before "Ready" shows modal with current status message (e.g. sync pct enabling)

Will work towards applying the above to init_z_coin / inti_zcoin_status and init_withdraw / withdraw_status methods - @SylEze @tonymorony if you have other ideas for how to better communicate this in GUI, please let me know.

[tonymorony]

@smk762 could you please sync this branch with dev?

Right now it's not building since mm2 artefact linked in it not available anymore

[tonymorony]

@smk762 I've merged couple things and now there are a few conflicts

[Canialon]

In general, this pr looks good to me^^ Thanks!
Except for this faucet window, the text doesn’t fit and overflows. I'm unsure if we need to fix it in this pr or create a separate one.

[smk762]

In general, this pr looks good to me^^ Thanks! Except for this faucet window, the text doesn’t fit and overflows. I'm unsure if we need to fix it in this pr or create a separate one.

Thanks for finding - I've updated the faucet to make the message shorter and it should fit now.

[cipig]

id is arrr-pirate, like in https://coinpaprika.com/coin/arrr-pirate/

[cipig]

orderbook shows wrong info... in this case it shows an ask of 210 PND, but the order is with 270559 PND... when i click on that ask the volume in order placing gets prefilled with 270559, so the correct value is present... idk where 210 comes from

ok, i know where the wrong value comes from... this is the order:

    "asks": [
      {
        "coin": "PND",
        "address": {
          "address_type": "Transparent",
          "address_data": "PSTLtpVU4wDLRxu8Dd6vmAVvdWWxA1i4E8"
        },
        "price": {
          "decimal": "0.0007777"
        },
        "pubkey": "031bb83b58ec130e28e0a6d5d2acf2eb01b0d3f1670e021d47d31db8a858219da8",
        "uuid": "6c56f42d-3c36-4a2e-959b-0fb6be51bdfb",
        "is_mine": false,
        "base_max_volume": {
          "decimal": "270599.478456"
        },
        "base_min_volume": {
          "decimal": "10"
        },
        "rel_max_volume": {
          "decimal": "210.4452143952312"
        },
        "rel_min_volume": {
          "decimal": "0.007777"
        },
        "conf_settings": {
          "base_confs": 1,
          "base_nota": false,
          "rel_confs": 4,
          "rel_nota": false
        },
        "base_max_volume_aggr": {
          "decimal": "270599.478456"
        },
        "rel_max_volume_aggr": {
          "decimal": "210.4452143952312"
        }
      }
    ],

Desktop uses rel_max_volume instead of base_max_volume

[cipig]

ask is now fixed, but bid is wrong

it should be 2 KMD for 11554 PND, like in the output from curl -s --url "http://127.0.0.1:7783" --data "{\"mmrpc\":\"2.0\",\"userpass\":\"$userpass\",\"method\":\"orderbook\",\"params\": {\"base\":\"PND\",\"rel\":\"KMD\"}}":

    "base": "PND",
    "bids": [
      {
        "coin": "KMD",
        "address": {
          "address_type": "Transparent",
          "address_data": "RT9MpMyucqXiX8bZLimXBnrrn2ofmdGNKd"
        },
        "price": {
          "decimal": "0.0001731002250302925393803011943915527090185217240782413017136922277998961398649818244763718192833650684"
        },
        "pubkey": "031bb83b58ec130e28e0a6d5d2acf2eb01b0d3f1670e021d47d31db8a858219da8",
        "uuid": "bee33e59-eb29-4f0f-8286-dcf04cc1b38d",
        "is_mine": false,
        "base_max_volume": {
          "decimal": "11554"
        },
        "base_min_volume": {
          "decimal": "10"
        },
        "rel_max_volume": {
          "decimal": "2"
        },
        "rel_min_volume": {
          "decimal": "0.001731002250302925393803011943915527090185217240782413017136922277998961398649818244763718192833650684"
        },
        "conf_settings": {
          "base_confs": 1,
          "base_nota": false,
          "rel_confs": 4,
          "rel_nota": false
        },
        "base_max_volume_aggr": {
          "decimal": "11554"
        },
        "rel_max_volume_aggr": {
          "decimal": "2"
        }
      }
    ],

that's how it should look like:

[cipig]

orderbook is fixed, thanks
but best_orders are not showing up, instead there is an error in mm2.log related to it (shows up every time i click on an order in orderbook)

07 00:55:53, rpc:173] ERROR RPC dispatcher error: dispatcher:94] Error parsing request: missing field `request_by`

[Canialon]

Noticed just now, zombie colourful name is not visible very good on a dark theme. Can you change the color of it somehow (or is it necessary at all)?