Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visual fixes #1809

Closed
wants to merge 46 commits into from
Closed

Visual fixes #1809

wants to merge 46 commits into from

Conversation

smk762
Copy link
Collaborator

@smk762 smk762 commented Jun 21, 2022 •
edited
Loading

closes #1808
closes #1810
closes #1811
closes #1812
closes #1813
closes #1815

@smk762 smk762 requested review from a user, tonymorony, cipig, SirSevenG and Canialon June 21, 2022 13:48
@cipig
Copy link
Member

cipig commented Jun 21, 2022

image
on smallest possible window site it looks like that here

cipig
cipig previously approved these changes Jun 21, 2022
View reviewed changes
SirSevenG
SirSevenG suggested changes Jun 21, 2022
View reviewed changes
Copy link

@SirSevenG SirSevenG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Custom protection overlaps fee details:

image

@cipig
Copy link
Member

cipig commented Jun 21, 2022

image
weird, don't have it here

@smk762 smk762 changed the title fix overflow Visual fixes Jun 22, 2022
@smk762
Copy link
Collaborator Author

smk762 commented Jun 22, 2022 •
edited
Loading

Custom protection overlaps fee details:

image

Custom protection overlaps fee details:

image

I am not able to replicate this
image

image

I've attached a few extra issues to this PR and updated the first comment accordingly.

@smk762 smk762 requested review from SirSevenG and cipig June 22, 2022 09:12
@smk762 smk762 requested a review from SirSevenG June 29, 2022 12:46
@cipig
Copy link
Member

cipig commented Jun 30, 2022

image
custom confirmation settings fixed

@smk762
Copy link
Collaborator Author

smk762 commented Jul 1, 2022

@SirSevenG can you please confirm the changes you requested are resolved?

@Canialon
Copy link

Canialon commented Jul 1, 2022

simple button overflow on big window size

wider window -> wider button -> button overflow
image

Screen.Recording.2022-07-01.at.11.54.41.mov

repeated on mac and windows CI build

SirSevenG
SirSevenG approved these changes Jul 1, 2022
View reviewed changes
Copy link

@SirSevenG SirSevenG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smk762 smk762 mentioned this pull request Jul 1, 2022
Closed
@smk762 smk762 closed this Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SirSevenG SirSevenG SirSevenG approved these changes

@cipig cipig cipig approved these changes

@tonymorony tonymorony Awaiting requested review from tonymorony

@Canialon Canialon Awaiting requested review from Canialon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
6 participants
@smk762 @cipig @SirSevenG @Canialon @tonymorony @actioncoininc