Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix custom fees #1843

Merged
merged 2 commits into from
Jul 4, 2022
Merged

fix custom fees #1843

merged 2 commits into from
Jul 4, 2022

Conversation

smk762
Copy link
Collaborator

@smk762 smk762 commented Jul 3, 2022

closes: #1753

@smk762 smk762 requested review from a user, tonymorony, cipig, SirSevenG and Canialon July 3, 2022 19:35
@cipig
Copy link
Member

cipig commented Jul 4, 2022 •
edited
Loading

image
PLG20 and UTXO coins now have 3 input fields... should be one (the first in screenshot) for UTXO coins and 2 for EVM coins (2-3 in screenshot)

saw this warning on console, could be related

[00:02:41] [warning] [main.prerequisites.hpp:92] [2141930]: qrc:/Dex/Wallet/SendModal.qml:621:17: Unable to assign [undefined] to bool

@smk762
Copy link
Collaborator Author

smk762 commented Jul 4, 2022

Apologies @cipig I left a couple of backend files off the last commit

SirSevenG
SirSevenG approved these changes Jul 4, 2022
View reviewed changes
Copy link

@SirSevenG SirSevenG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, was able to send a few transactions with custom fee with no issues

cipig
cipig approved these changes Jul 4, 2022
View reviewed changes
Copy link
Member

@cipig cipig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. working fine now
tested with PLG20 and UTXO

@smk762 smk762 merged commit db96c94 into dev Jul 4, 2022
@ghost ghost deleted the custom_fees branch September 15, 2022 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SirSevenG SirSevenG SirSevenG approved these changes

@cipig cipig cipig approved these changes

@tonymorony tonymorony Awaiting requested review from tonymorony

@Canialon Canialon Awaiting requested review from Canialon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: using custom fee when sending does not work
3 participants
@smk762 @cipig @SirSevenG