Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update api to beta-2.1.7132 #1896

Merged
merged 1 commit into from
Jul 29, 2022
Merged

update api to beta-2.1.7132 #1896

merged 1 commit into from
Jul 29, 2022

Conversation

tonymorony
Copy link

please perform sanity trading test

@tonymorony tonymorony requested review from smk762, SirSevenG and Canialon and removed request for Canialon July 29, 2022 10:33
@smk762
Copy link
Collaborator

smk762 commented Jul 29, 2022

I'm seeing some weird results which I cant replicate in a locally build dev branch.

  • Bestorders is not populating at all, making simple mode unusable.
  • Sometime when flipping between buy/sell and using the combo box ticker switch button, the orderbook ends up looking a bit wrong
    image
    Will need to investigate further to determine why.

@tonymorony
Copy link
Author

hmm, weird @smk762 works fine on my side

image

Copy link
Collaborator

@smk762 smk762 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah was weird. Seems an isolated issue tho, after adding extra logs and building locally everything works as expected. Re-downloaded binaries also to re-test and performed swap without issue.

@tonymorony tonymorony merged commit 18cff55 into dev Jul 29, 2022
@smk762 smk762 deleted the api-beta-2.1.7132 branch August 7, 2023 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants