Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve frontend coin logic #2042

Merged
merged 4 commits into from
Nov 4, 2022
Merged

Improve frontend coin logic #2042

merged 4 commits into from
Nov 4, 2022

Conversation

ghost
Copy link

@ghost ghost commented Nov 3, 2022

@ghost ghost requested review from cipig and smk762 November 3, 2022 14:18
Copy link
Collaborator

@smk762 smk762 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok - but I cant test with PIRATE because coins file is old, but confirmed zombie wont allow disable while activating

@cipig
Copy link
Member

cipig commented Nov 4, 2022

should this apply to all "parent" coins? I can disable BNB while all the BEP20 tokens remain enabled.

@ghost
Copy link
Author

ghost commented Nov 4, 2022

should this apply to all "parent" coins? I can disable BNB while all the BEP20 tokens remain enabled.

This is happenning outside this branch and there is already an issue related to that no ? In any case this PR does not change disabling logic, it's about a predicate that tells if you can disable or not a coin.

@tonymorony tonymorony merged commit 79cc4d2 into dev Nov 4, 2022
@smk762 smk762 mentioned this pull request Nov 18, 2022
@smk762 smk762 deleted the improve-frontend-coin-logic branch August 7, 2023 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants