Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tweak custom fees display #2099

Merged
merged 2 commits into from
Nov 18, 2022
Merged

tweak custom fees display #2099

merged 2 commits into from
Nov 18, 2022

Conversation

smk762
Copy link
Collaborator

@smk762 smk762 commented Nov 17, 2022

  • Added function for custom fee type
  • Hides custom fees for GLMR / SLP / ZHTLC / QTUM until related issues are resolved or functionality exists (see [BUG]: Custom fee issues #2092)

To Test:

  • Confirm custom fees toggle / inputs not visible for GLMR / SLP / ZHTLC / QRC20 coins
  • Confirm custom fees toggle / gas inputs visible for other EVM coins
  • Confirm custom fees toggle / utxo inputs visible for UTXO coins

@smk762 smk762 requested review from a user, SirSevenG, Canialon and cipig November 17, 2022 19:41
SirSevenG
SirSevenG previously approved these changes Nov 18, 2022
View reviewed changes
Copy link

@SirSevenG SirSevenG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Canialon
Canialon previously approved these changes Nov 18, 2022
View reviewed changes
@smk762 smk762 dismissed stale reviews from Canialon and SirSevenG via ee5c095 November 18, 2022 10:53
@smk762 smk762 merged commit bc6f712 into dev Nov 18, 2022
@smk762 smk762 deleted the custom_fees_fix branch August 7, 2023 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Canialon Canialon Canialon left review comments

@SirSevenG SirSevenG SirSevenG left review comments

@cipig cipig Awaiting requested review from cipig

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smk762 @SirSevenG @Canialon