-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
no console logs for release builds #2201
Conversation
I believe the problem mentioned in issue was not the logs itself but the fact that logs writing into what is the QT feature introduced in 0.5.6 https://www.ics.com/blog/whats-new-qt-560-logging-syslog-and-journald
so just logging backend removal is needed (we do have timestamped logs file on every session so no need to write it to other places) why do we need temp.txt log file? |
I saw that article when investigating the problem.
App is not configured to write to syslog.
The strings
This is a way to get the response returned from https://github.com/KomodoPlatform/atomicDEX-Desktop/blob/dev/src/core/atomicdex/utilities/kill.cpp#L29 so that More context: #2171 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this disables console log completely
if that is the intention, then it works
can't tell anything about syslog though, it didn't had that problem on linux myself
Did you launch from file manager? If so do you know which one? |
Oh... no, i didn't... just unpacked and started |
@smk762 do you have a build file that i can test? Edit: found a build to test https://github.com/KomodoPlatform/atomicDEX-Desktop/actions/runs/3973225190 |
Ok, i unzipped on CLI and started with FileManager (which doesn't make that much sense, since it's more work to switch to file manager and click me through till i get to the place where the binary is located... but ok, just to test)
but that's it, nothing more in syslog |
my Ubuntu 20.04 Desktop is installed with one 1 user (non-root) account and i can tail the syslog file without though it is not possible in my server running Debian, where user setup is same. i am guessing it varies depending on OS/flavor. |
@smk762 it appears the issue i was seeing is fixed with builds from this PR
i no longer see the full logs being shown in syslog file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't seen app logs in syslog here
@tonymorony please merge if you are happy with this PR in its current state. |
Closes #2171
To test:
tail -f /var/log/syslog
.cc: @himu007