Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0.5.7 -> 0.5.7.1 #2217

Merged
merged 3 commits into from
Mar 6, 2023
Merged

0.5.7 -> 0.5.7.1 #2217

merged 3 commits into from
Mar 6, 2023

Conversation

smk762
Copy link
Collaborator

@smk762 smk762 commented Mar 4, 2023

Updates version to 0.5.7.1

@smk762
Copy link
Collaborator Author

smk762 commented Mar 5, 2023

To test: launch app and check in settings that the following values are present
image

@smk762 smk762 requested a review from tonymorony March 5, 2023 11:46
@smk762
Copy link
Collaborator Author

smk762 commented Mar 5, 2023

CI builds at https://github.com/KomodoPlatform/atomicDEX-Desktop/actions/runs/4331570383

SirSevenG
SirSevenG previously approved these changes Mar 6, 2023
View reviewed changes
@smk762 smk762 mentioned this pull request Mar 6, 2023
Merged
Canialon
Canialon suggested changes Mar 6, 2023
View reviewed changes
Copy link

@Canialon Canialon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coins file does not exist! :'(

image

@smk762
Copy link
Collaborator Author

smk762 commented Mar 6, 2023

replicated here on one wallet (others are ok). Will fix asap.

[19:46:02] [debug] [mm2.service.cpp:200] [657451]: retrieve_coins_informations
[19:46:02] [debug] [mm2.service.cpp:54] [657451]: checking for reconfiguration
[19:46:02] [info] [mm2.service.cpp:66] [657451]: opening file: /home/smk762/.atomic_qt/config/0.5.7.1-coins.EGGS.json
[19:46:02] [info] [mm2.service.cpp:63] [657451]: There is a precedent configuration file, upgrading the new one with precedent settings
[19:46:02] [info] [mm2.service.cpp:75] [657451]: opening file: /home/smk762/.atomic_qt/config/0.5.7.1-coins.EGGS.json
[19:46:02] [info] [mm2.service.cpp:100] [657451]: closing file: /home/smk762/.atomic_qt/config/0.5.7.1-coins.EGGS.json
[19:46:02] [info] [mm2.service.cpp:102] [657451]: closing file: /home/smk762/.atomic_qt/config/0.5.7.1-coins.EGGS.json
[19:46:02] [info] [mm2.service.cpp:106] [657451]: opening file: /home/smk762/.atomic_qt/config/0.5.7.1-coins.EGGS.json
[19:46:02] [info] [mm2.service.cpp:119] [657451]: closing file: /home/smk762/.atomic_qt/config/0.5.7.1-coins.EGGS.json
[19:46:02] [info] [mm2.service.cpp:207] [657451]: Retrieving Wallet information of /home/smk762/.atomic_qt/config/0.5.7.1-coins.EGGS.json
[19:46:02] [debug] [mm2.service.cpp:237] [657451]: Coins file does not exist!
[19:46:02] [info] [qt.global.coins.cfg.model.cpp:210] [657451]: Initializing global coin cfg model with size 1
[19:46:02] [debug] [mm2.service.cpp:237] [657451]: Coins file does not exist!

@Canialon Canialon self-requested a review March 6, 2023 11:55
@smk762 smk762 requested a review from SirSevenG March 6, 2023 12:15
Canialon
Canialon approved these changes Mar 6, 2023
View reviewed changes
Copy link

@Canialon Canialon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

coin file back:) version 0.5.7.1-beta
Thanks!

@smk762 smk762 merged commit 146b1ea into dev Mar 6, 2023
@smk762 smk762 deleted the update_version_0571 branch August 7, 2023 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Canialon Canialon Canialon approved these changes

@tonymorony tonymorony tonymorony approved these changes

@cipig cipig Awaiting requested review from cipig

@endrilickollari endrilickollari Awaiting requested review from endrilickollari

@gcharang gcharang Awaiting requested review from gcharang

@SirSevenG SirSevenG Awaiting requested review from SirSevenG

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@smk762 @tonymorony @SirSevenG @Canialon