Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add KIP0001 #2220

Merged
merged 1 commit into from
Mar 6, 2023
Merged

Add KIP0001 #2220

merged 1 commit into from
Mar 6, 2023

Conversation

smk762
Copy link
Collaborator

@smk762 smk762 commented Mar 4, 2023

Adds KIP0001 as a default, wallet only coin.

@smk762
Copy link
Collaborator Author

smk762 commented Mar 5, 2023

CI builds: https://github.com/KomodoPlatform/atomicDEX-Desktop/actions/runs/4331663377

SirSevenG
SirSevenG approved these changes Mar 6, 2023
View reviewed changes
Copy link

@SirSevenG SirSevenG left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • enabled on new wallets
  • can be activated on old wallets
  • KIP coin works normally
  • Is wallet-only

Canialon
Canialon approved these changes Mar 6, 2023
View reviewed changes
Copy link

@Canialon Canialon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ activate
✅ deactivate
✅ receive
✅ send
✅ wallet only; is not visible on DEX
✅ private key

@smk762 smk762 merged commit 626b4b9 into dev Mar 6, 2023
@smk762 smk762 deleted the add_kip0001 branch March 6, 2023 11:07
@smk762 smk762 mentioned this pull request Mar 6, 2023
Merged
@damascene damascene mentioned this pull request Mar 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Canialon Canialon Canialon approved these changes

@SirSevenG SirSevenG SirSevenG approved these changes

@cipig cipig Awaiting requested review from cipig

@endrilickollari endrilickollari Awaiting requested review from endrilickollari

@gcharang gcharang Awaiting requested review from gcharang

@tonymorony tonymorony Awaiting requested review from tonymorony

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smk762 @SirSevenG @Canialon