Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle button where no notifications #2262

Merged
merged 1 commit into from
Apr 13, 2023
Merged

handle button where no notifications #2262

merged 1 commit into from
Apr 13, 2023

Conversation

smk762
Copy link
Collaborator

@smk762 smk762 commented Apr 13, 2023

Closes #2258

To test: View your notifications when the list is empty. The button should have different text as below:

notif.mp4

@smk762 smk762 added the 0.5.7.2 label Apr 13, 2023
endrilickollari
endrilickollari approved these changes Apr 13, 2023
View reviewed changes
Copy link

@endrilickollari endrilickollari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When there are notifications:

image

When read all notifications:

image

@smk762 smk762 merged commit 8d5ac29 into dev Apr 13, 2023
@smk762 smk762 deleted the fix-notifications-btn branch August 7, 2023 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@endrilickollari endrilickollari endrilickollari approved these changes

@cipig cipig cipig approved these changes

@Canialon Canialon Awaiting requested review from Canialon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FR]: Remove read all notifications while no notifications to read
4 participants
@smk762 @cipig @endrilickollari @Canialon