Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and ercv2 boilerplate #2395

Merged
merged 44 commits into from
Dec 21, 2023
Merged

Refactor and ercv2 boilerplate #2395

merged 44 commits into from
Dec 21, 2023

Conversation

smk762
Copy link
Collaborator

@smk762 smk762 commented Dec 20, 2023

This adds the boilerplate code for erc20 v2 activation. Unfortunately, it is still a little unstable so the old methods will still be used for now, but this code is good to go for entering the codebase.

Along the way, the following items were completed:

  • Short term solution for https://github.com/KomodoPlatform/komodo-wallet-desktop/issues/2371
  • Updated orderbook and bestorders to v2 and moved to use more efficient async request
  • Added PeerId display to settings > about
  • Misc refactoring, tweaking of logs, code commenting and variables renamed to be more descriptive of purpose
  • Fixed custom coin adding form (fixed BEP/ERC, disabled QRC)
  • Improved the activation flow by implementing an activation_queue to split large selections into smaller chunks with slight delays in between to avoid overloading,
  • Added comparisons between the m_activation_queue / currently_enabled registries and the get_enabled_coins rpc response to ensure coins active in mm2 are visible in app, and no repeated attempts at activation on an active coin are made.
  • Added links to markets info and orderbooks, requested here https://github.com/KomodoPlatform/komodo-wallet-desktop/issues/1946
  • Fixed percentage display of ZHTLC assets while activating, and set up signal connection to keep all front end percentage displays in sync
  • Added Explore button for coin wallet pages which have a block explorer in coins_config.json

@smk762 smk762 changed the title Activation v2 boilerplate Refactor and ercv2 boilerplate (disabled) Dec 20, 2023
@smk762 smk762 requested review from cipig and kivqa December 20, 2023 12:41
@smk762 smk762 changed the title Refactor and ercv2 boilerplate (disabled) Refactor and ercv2 boilerplate Dec 20, 2023
@smk762 smk762 mentioned this pull request Dec 20, 2023
@smk762 smk762 merged commit 42fea1a into v7-dev Dec 21, 2023
6 checks passed
@ca333 ca333 deleted the activation-v2-boilerplate branch October 23, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant