-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor and ercv2 boilerplate #2395
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smk762
changed the title
Activation v2 boilerplate
Refactor and ercv2 boilerplate (disabled)
Dec 20, 2023
smk762
changed the title
Refactor and ercv2 boilerplate (disabled)
Refactor and ercv2 boilerplate
Dec 20, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the boilerplate code for erc20 v2 activation. Unfortunately, it is still a little unstable so the old methods will still be used for now, but this code is good to go for entering the codebase.
Along the way, the following items were completed:
settings > about
activation_queue
to split large selections into smaller chunks with slight delays in between to avoid overloading,m_activation_queue
/currently_enabled
registries and theget_enabled_coins
rpc response to ensure coins active in mm2 are visible in app, and no repeated attempts at activation on an active coin are made.Explore
button for coin wallet pages which have a block explorer in coins_config.json