Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

open lcw when chart is clicked #2421

Merged
merged 2 commits into from
Apr 4, 2024
Merged

open lcw when chart is clicked #2421

merged 2 commits into from
Apr 4, 2024

Conversation

smk762
Copy link
Collaborator

@smk762 smk762 commented Apr 1, 2024

Closes: https://github.com/KomodoPlatform/komodo-wallet-desktop/issues/2418

To test:

  • login and go to DEX tab
  • select a pair which shows a chart
  • click anywhere on the chart
  • see https://www.livecoinwatch.com/ open in a tab in your default browser.

Known issues/limitations:

  • As the chart code is generated by 3rd party JS, we cant just change how the hyperlink in the bottom left corner responds when clicked on, so instead the whole chart area is now "active" - you can click anywhere on the chart and it will open LCW.

Copy link
Collaborator

@AndrewDelaney AndrewDelaney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing successful.
Clicking on the graph for any valid coin will open Live Coin Watch website in browser.

It would be useful to have the graph open the website on the specific coin being viewed in Komodo Wallet, however, obtaining the correct URL for the individual coin might prove difficult dealing with a third party website; seems unnecessary for this update.

@smk762
Copy link
Collaborator Author

smk762 commented Apr 4, 2024

Unfortunately the url format was not exactly the same as the api ids data we have to generate the chart.

@smk762 smk762 merged commit da0f8ff into dev Apr 4, 2024
6 checks passed
@smk762 smk762 deleted the fix/chart-hyperlink branch April 4, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Live Coin Watch graph hyperlink is not usable
2 participants