fix unconfirmed change note tracking in transactions #10
Clippy (nightly)
2 errors, 189 warnings
Details
Results
Message level | Amount |
---|---|
Internal compiler error | 0 |
Error | 2 |
Warning | 189 |
Note | 0 |
Help | 0 |
Versions
- rustc 1.85.0-nightly (acabb5248 2024-12-04)
- cargo 1.85.0-nightly (05f54fdc3 2024-12-03)
- clippy 0.1.85 (acabb52482 2024-12-04)
Annotations
Check warning on line 477 in zcash_client_sqlite/src/lib.rs
github-actions / Clippy (nightly)
this expression creates a reference which is immediately dereferenced by the compiler
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> zcash_client_sqlite/src/lib.rs:477:50
|
477 | let tx_ref = wallet::put_tx_data(up, &sent_tx.tx, Some(sent_tx.created))?;
| ^^^^^^^^^^^ help: change this to: `sent_tx.tx`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Check warning on line 415 in zcash_client_sqlite/src/lib.rs
github-actions / Clippy (nightly)
this expression creates a reference which is immediately dereferenced by the compiler
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> zcash_client_sqlite/src/lib.rs:415:54
|
415 | let tx_row = wallet::put_tx_meta(up, &tx, block.block_height)?;
| ^^^ help: change this to: `tx`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Check warning on line 410 in zcash_client_sqlite/src/lib.rs
github-actions / Clippy (nightly)
this expression creates a reference which is immediately dereferenced by the compiler
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> zcash_client_sqlite/src/lib.rs:410:17
|
410 | &block.commitment_tree,
| ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `block.commitment_tree`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Check warning on line 395 in zcash_client_sqlite/src/lib.rs
github-actions / Clippy (nightly)
the following explicit lifetimes could be elided: 'a
warning: the following explicit lifetimes could be elided: 'a
--> zcash_client_sqlite/src/lib.rs:395:6
|
395 | impl<'a, P: consensus::Parameters> WalletWrite for DataConnStmtCache<'a, P> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
395 - impl<'a, P: consensus::Parameters> WalletWrite for DataConnStmtCache<'a, P> {
395 + impl<P: consensus::Parameters> WalletWrite for DataConnStmtCache<'_, P> {
|
Check warning on line 367 in zcash_client_sqlite/src/lib.rs
github-actions / Clippy (nightly)
the following explicit lifetimes could be elided: 'a
warning: the following explicit lifetimes could be elided: 'a
--> zcash_client_sqlite/src/lib.rs:367:6
|
367 | impl<'a, P: consensus::Parameters> DataConnStmtCache<'a, P> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
367 - impl<'a, P: consensus::Parameters> DataConnStmtCache<'a, P> {
367 + impl<P: consensus::Parameters> DataConnStmtCache<'_, P> {
|
Check warning on line 282 in zcash_client_sqlite/src/lib.rs
github-actions / Clippy (nightly)
the following explicit lifetimes could be elided: 'a
warning: the following explicit lifetimes could be elided: 'a
--> zcash_client_sqlite/src/lib.rs:282:6
|
282 | impl<'a, P: consensus::Parameters> WalletRead for DataConnStmtCache<'a, P> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
282 - impl<'a, P: consensus::Parameters> WalletRead for DataConnStmtCache<'a, P> {
282 + impl<P: consensus::Parameters> WalletRead for DataConnStmtCache<'_, P> {
|
Check warning on line 765 in zcash_client_sqlite/src/wallet.rs
github-actions / Clippy (nightly)
the following explicit lifetimes could be elided: 'a
warning: the following explicit lifetimes could be elided: 'a
--> zcash_client_sqlite/src/wallet.rs:765:25
|
765 | pub fn insert_sent_note<'a, P: consensus::Parameters>(
| ^^
766 | stmts: &mut DataConnStmtCache<'a, P>,
| ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
765 ~ pub fn insert_sent_note<P: consensus::Parameters>(
766 ~ stmts: &mut DataConnStmtCache<'_, P>,
|
Check warning on line 718 in zcash_client_sqlite/src/wallet.rs
github-actions / Clippy (nightly)
the following explicit lifetimes could be elided: 'a
warning: the following explicit lifetimes could be elided: 'a
--> zcash_client_sqlite/src/wallet.rs:718:22
|
718 | pub fn put_sent_note<'a, P: consensus::Parameters>(
| ^^
719 | stmts: &mut DataConnStmtCache<'a, P>,
| ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
718 ~ pub fn put_sent_note<P: consensus::Parameters>(
719 ~ stmts: &mut DataConnStmtCache<'_, P>,
|
Check warning on line 680 in zcash_client_sqlite/src/wallet.rs
github-actions / Clippy (nightly)
the following explicit lifetimes could be elided: 'a
warning: the following explicit lifetimes could be elided: 'a
--> zcash_client_sqlite/src/wallet.rs:680:23
|
680 | pub fn insert_witness<'a, P>(
| ^^
681 | stmts: &mut DataConnStmtCache<'a, P>,
| ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
680 ~ pub fn insert_witness<P>(
681 ~ stmts: &mut DataConnStmtCache<'_, P>,
|
Check warning on line 662 in zcash_client_sqlite/src/wallet.rs
github-actions / Clippy (nightly)
this expression creates a reference which is immediately dereferenced by the compiler
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> zcash_client_sqlite/src/wallet.rs:662:55
|
662 | stmts.stmt_insert_received_note.execute_named(&sql_args)?;
| ^^^^^^^^^ help: change this to: `sql_args`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Check warning on line 660 in zcash_client_sqlite/src/wallet.rs
github-actions / Clippy (nightly)
this expression creates a reference which is immediately dereferenced by the compiler
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> zcash_client_sqlite/src/wallet.rs:660:54
|
660 | if stmts.stmt_update_received_note.execute_named(&sql_args)? == 0 {
| ^^^^^^^^^ help: change this to: `sql_args`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Check warning on line 656 in zcash_client_sqlite/src/wallet.rs
github-actions / Clippy (nightly)
this expression creates a reference which is immediately dereferenced by the compiler
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> zcash_client_sqlite/src/wallet.rs:656:10
|
656 | (&":output_index", &output_index),
| ^^^^^^^^^^^^^^^^ help: change this to: `":output_index"`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Check warning on line 655 in zcash_client_sqlite/src/wallet.rs
github-actions / Clippy (nightly)
this expression creates a reference which is immediately dereferenced by the compiler
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> zcash_client_sqlite/src/wallet.rs:655:10
|
655 | (&":tx", &tx),
| ^^^^^^ help: change this to: `":tx"`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Check warning on line 654 in zcash_client_sqlite/src/wallet.rs
github-actions / Clippy (nightly)
this expression creates a reference which is immediately dereferenced by the compiler
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> zcash_client_sqlite/src/wallet.rs:654:10
|
654 | (&":is_change", &is_change),
| ^^^^^^^^^^^^^ help: change this to: `":is_change"`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Check warning on line 653 in zcash_client_sqlite/src/wallet.rs
github-actions / Clippy (nightly)
this expression creates a reference which is immediately dereferenced by the compiler
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> zcash_client_sqlite/src/wallet.rs:653:10
|
653 | (&":memo", &memo),
| ^^^^^^^^ help: change this to: `":memo"`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Check warning on line 652 in zcash_client_sqlite/src/wallet.rs
github-actions / Clippy (nightly)
this expression creates a reference which is immediately dereferenced by the compiler
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> zcash_client_sqlite/src/wallet.rs:652:10
|
652 | (&":nf", &nf_bytes),
| ^^^^^^ help: change this to: `":nf"`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Check warning on line 651 in zcash_client_sqlite/src/wallet.rs
github-actions / Clippy (nightly)
this expression creates a reference which is immediately dereferenced by the compiler
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> zcash_client_sqlite/src/wallet.rs:651:10
|
651 | (&":rcm", &rcm),
| ^^^^^^^ help: change this to: `":rcm"`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Check warning on line 650 in zcash_client_sqlite/src/wallet.rs
github-actions / Clippy (nightly)
this expression creates a reference which is immediately dereferenced by the compiler
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> zcash_client_sqlite/src/wallet.rs:650:10
|
650 | (&":value", &value),
| ^^^^^^^^^ help: change this to: `":value"`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Check warning on line 649 in zcash_client_sqlite/src/wallet.rs
github-actions / Clippy (nightly)
this expression creates a reference which is immediately dereferenced by the compiler
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> zcash_client_sqlite/src/wallet.rs:649:10
|
649 | (&":diversifier", &diversifier),
| ^^^^^^^^^^^^^^^ help: change this to: `":diversifier"`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Check warning on line 648 in zcash_client_sqlite/src/wallet.rs
github-actions / Clippy (nightly)
this expression creates a reference which is immediately dereferenced by the compiler
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> zcash_client_sqlite/src/wallet.rs:648:10
|
648 | (&":account", &account),
| ^^^^^^^^^^^ help: change this to: `":account"`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Check warning on line 631 in zcash_client_sqlite/src/wallet.rs
github-actions / Clippy (nightly)
the following explicit lifetimes could be elided: 'a
warning: the following explicit lifetimes could be elided: 'a
--> zcash_client_sqlite/src/wallet.rs:631:26
|
631 | pub fn put_received_note<'a, P, T: ShieldedOutput>(
| ^^
632 | stmts: &mut DataConnStmtCache<'a, P>,
| ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
631 ~ pub fn put_received_note<P, T: ShieldedOutput>(
632 ~ stmts: &mut DataConnStmtCache<'_, P>,
|
Check warning on line 616 in zcash_client_sqlite/src/wallet.rs
github-actions / Clippy (nightly)
the following explicit lifetimes could be elided: 'a
warning: the following explicit lifetimes could be elided: 'a
--> zcash_client_sqlite/src/wallet.rs:616:19
|
616 | pub fn mark_spent<'a, P>(
| ^^
617 | stmts: &mut DataConnStmtCache<'a, P>,
| ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
616 ~ pub fn mark_spent<P>(
617 ~ stmts: &mut DataConnStmtCache<'_, P>,
|
Check warning on line 578 in zcash_client_sqlite/src/wallet.rs
github-actions / Clippy (nightly)
the following explicit lifetimes could be elided: 'a
warning: the following explicit lifetimes could be elided: 'a
--> zcash_client_sqlite/src/wallet.rs:578:20
|
578 | pub fn put_tx_data<'a, P>(
| ^^
579 | stmts: &mut DataConnStmtCache<'a, P>,
| ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
578 ~ pub fn put_tx_data<P>(
579 ~ stmts: &mut DataConnStmtCache<'_, P>,
|
Check warning on line 551 in zcash_client_sqlite/src/wallet.rs
github-actions / Clippy (nightly)
the following explicit lifetimes could be elided: 'a
warning: the following explicit lifetimes could be elided: 'a
--> zcash_client_sqlite/src/wallet.rs:551:20
|
551 | pub fn put_tx_meta<'a, P, N>(
| ^^
552 | stmts: &mut DataConnStmtCache<'a, P>,
| ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
551 ~ pub fn put_tx_meta<P, N>(
552 ~ stmts: &mut DataConnStmtCache<'_, P>,
|
Check warning on line 529 in zcash_client_sqlite/src/wallet.rs
github-actions / Clippy (nightly)
the following explicit lifetimes could be elided: 'a
warning: the following explicit lifetimes could be elided: 'a
--> zcash_client_sqlite/src/wallet.rs:529:21
|
529 | pub fn insert_block<'a, P>(
| ^^
530 | stmts: &mut DataConnStmtCache<'a, P>,
| ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `-W clippy::needless-lifetimes` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::needless_lifetimes)]`
help: elide the lifetimes
|
529 ~ pub fn insert_block<P>(
530 ~ stmts: &mut DataConnStmtCache<'_, P>,
|