-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support online validation with Konnect #1335
Open
GGabriele
wants to merge
12
commits into
main
Choose a base branch
from
feat/konnect_validate
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+307
−11
Open
Changes from 2 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
dc80a8d
feat: support online validation with Konnect
GGabriele e07f7b0
Merge branch 'main' into feat/konnect_validate
Prashansa-K a05a422
tests: Added e2e tests for gateway validation with konnect.
Prashansa-K 419a953
chore: lint fix
Prashansa-K a904b53
Merge branch 'main' into feat/konnect_validate
Prashansa-K 4e75b4c
chore: removed workspace flag test as it is not supported with konnect
Prashansa-K b05d593
tests: added rbac-resources file
Prashansa-K dff8245
refactor: refactored tests and code to add all konnect validate usecases
Prashansa-K 1361bfd
chore: fixed workspace setting for Konnect check
Prashansa-K 1e7758b
chore: added mutually exclusive flags for konnect compatibility
Prashansa-K f91a6f4
chore: fixed logical error
Prashansa-K cf17473
chore: fixed descripancy in info due to preRun order in cobra
Prashansa-K File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I lack some context here. How is this addition related to this PR? @GGabriele
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ping: @GGabriele. Do you mind chiming in here? 🙇