-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add just eat kongverge integration to kong hub #1001
docs: add just eat kongverge integration to kong hub #1001
Conversation
* add index.md file for just eat kongverge integration * add logo for just eat kongverge integration
* add newline to end of kongverge index.md From Kong#1001
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for your addition to the Kong Hub!
* make documentation header level 2 * remove enterprise_edition compatibility From Kong#1001
Thanks for much for contributing to the Kong Hub - well done @Gadam8 !! |
Well shoot, now that I merged this and tried running or deploying the docs site, I'm getting an error:
And I'm having trouble fixing this - any ideas @Gadam8 ? I can't see anything wrong in your file that would cause this. |
Thanks for the merge. Line 2 column 1 is where the name is in the file, I can't see any issues there. The file seems fine, the only thing I can think of is the compatibility for EE is present but has no values? Apologies for the errors. |
@Gadam8 I'm not exactly sure what I did, but thanks for the clue - the issue was indeed somewhere in the compatibility section, despite that unhelpful error message :) It seems that #1017 fixes it - I'll merge and deploy now, you should see your new listing on https://docs.konghq.com/hub/ shortly! |
I'm glad it's all resolved, thanks for doing that. Apologies for all the back and forth :) That's brilliant, how exciting! Thank you for your time. |
* docs: add just eat kongverge integration to kong hub * add index.md file for just eat kongverge integration * add logo for just eat kongverge integration * docs: add just eat kongverge integration to kong hub * add newline to end of kongverge index.md * make documentation header level 2 * remove enterprise_edition compatibility * docs(hub-kongverge) display incompatibility
Summary
A PR to get the Just Eat Kongverge integration into Kong Hub. This includes the addition of a Just Eat publisher directory and a Kongverge extension in the _app/_hub directory. A logo was also added.
Full changelog
Issues resolved N/A
Checklist: