Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add just eat kongverge integration to kong hub #1001

Merged

Conversation

Gadam8
Copy link
Contributor

@Gadam8 Gadam8 commented Oct 29, 2018

Summary

A PR to get the Just Eat Kongverge integration into Kong Hub. This includes the addition of a Just Eat publisher directory and a Kongverge extension in the _app/_hub directory. A logo was also added.

Full changelog

  • added index.md file for just eat kongverge integration in docs
  • added logo for just eat kongverge integration in docs

Issues resolved N/A

Checklist:

Adam Gloyne added 2 commits October 26, 2018 16:04
* add index.md file for just eat kongverge integration
* add logo for just eat kongverge integration
* add newline to end of kongverge index.md

From Kong#1001
Copy link
Contributor

@coopr coopr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for your addition to the Kong Hub!

app/_hub/justeat/kongverge/index.md Show resolved Hide resolved
app/_hub/justeat/kongverge/index.md Outdated Show resolved Hide resolved
app/_hub/justeat/kongverge/index.md Outdated Show resolved Hide resolved
* make documentation header level 2
* remove enterprise_edition compatibility

From Kong#1001
@coopr coopr merged commit cba54b0 into Kong:master Nov 1, 2018
@coopr
Copy link
Contributor

coopr commented Nov 1, 2018

Thanks for much for contributing to the Kong Hub - well done @Gadam8 !!

@coopr
Copy link
Contributor

coopr commented Nov 1, 2018

Well shoot, now that I merged this and tried running or deploying the docs site, I'm getting an error:

Error: could not read file /Users/cooper/Documents/GitHub/docs.konghq.com/app/_hub/justeat/kongverge/index.md: (<unknown>): did not find expected key while parsing a block mapping at line 2 column 1

And I'm having trouble fixing this - any ideas @Gadam8 ? I can't see anything wrong in your file that would cause this.

@Gadam8
Copy link
Contributor Author

Gadam8 commented Nov 1, 2018

Thanks for the merge. Line 2 column 1 is where the name is in the file, I can't see any issues there. The file seems fine, the only thing I can think of is the compatibility for EE is present but has no values?

Apologies for the errors.

@coopr
Copy link
Contributor

coopr commented Nov 1, 2018

@Gadam8 I'm not exactly sure what I did, but thanks for the clue - the issue was indeed somewhere in the compatibility section, despite that unhelpful error message :)

It seems that #1017 fixes it - I'll merge and deploy now, you should see your new listing on https://docs.konghq.com/hub/ shortly!

@Gadam8
Copy link
Contributor Author

Gadam8 commented Nov 1, 2018

I'm glad it's all resolved, thanks for doing that. Apologies for all the back and forth :)

That's brilliant, how exciting! Thank you for your time.

kikito pushed a commit that referenced this pull request Dec 4, 2018
* docs: add just eat kongverge integration to kong hub

* add index.md file for just eat kongverge integration

* add logo for just eat kongverge integration

* docs: add just eat kongverge integration to kong hub

* add newline to end of kongverge index.md

* make documentation header level 2

* remove enterprise_edition compatibility

* docs(hub-kongverge) display incompatibility
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants