-
Notifications
You must be signed in to change notification settings - Fork 57
feat(exporter) export enterprise license info #110
Conversation
fffonion
commented
Feb 8, 2021
•
edited
Loading
edited
6d6f304
to
378da6e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just one small nit.
I did notice that dataplanes
, admin_seats
, product_subscription
, and support_plan
are not being parsed and added to the metrics collection which could add some value; don't think customer
, license_key
, and license_creation_date
would add value though.
This is Enterprise-specific code. I'm not sure why this is included here in an Open-source repository. I'd advise against including this here. And if we do decide to do this, please make sure you include the why in your commit message. |
Good call; didn't even notice that. This should be moved into Enterprise code base instead. |
Co-authored-by: Guilherme Salazar <gsz@acm.org>
i agree we can add |
I understand the pain here but that's really the right thing to do. You could add hooks tot he OSS code-base to ease with the pain. |
IMO this is not necessarily the 'wrong' approach, as there is no sensitive code being added -- the code here simply calls an enterprise-specific API. Moving it over to the enterprise side might add unnecessary maintenance burden. |