This repository has been archived by the owner on Aug 7, 2021. It is now read-only.
fix: skip sending status code after body is sent #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hishamhm
reviewed
Dec 14, 2018
This commit fixes a bug where the plugin tries to send HTTP status code after the response body is sent for `/metrics` endpoint. This resulted in error logs in Kong. A test has been added to ensure that no error logs are generated when `/metrics` is scraped by Prometheus. Another test has been added to ensure that the response body only contains either metrics or comments describing the metrics. This test is added to catch regression for Kong/kong#4077, where Kong injected HTML generated by the default Lapis handler. Fixes #32
hbagdi
force-pushed
the
fix/avoid-sending-status-code
branch
from
c3d304d
to
ab5e1a0
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a bug where the plugin tries to send HTTP status code
after the response body is sent for
/metricsendpoint.This resulted in error logs in Kong.
A test has been added to ensure that no error logs are generated when
/metricsis scraped by Prometheus.Another test has been added to ensure that the response body only
contains either metrics or comments describing the metrics.
This test is added to catch regression for
Kong/kong#4077, where Kong injected HTML
generated by the default Lapis handler.
Fixes #32