Skip to content
This repository has been archived by the owner on Aug 7, 2021. It is now read-only.

feat: expose prometheus object, resolve #73 #78

Merged
merged 1 commit into from
Mar 17, 2020
Merged

feat: expose prometheus object, resolve #73 #78

merged 1 commit into from
Mar 17, 2020

Conversation

aldor007
Copy link
Contributor

No description provided.

mpacholec
mpacholec approved these changes Mar 10, 2020
View reviewed changes
Copy link

@mpacholec mpacholec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@hishamhm hishamhm requested a review from fffonion March 16, 2020 14:53
fffonion
fffonion reviewed Mar 17, 2020
View reviewed changes
Copy link
Contributor

@fffonion fffonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me other than a small styling issue.

@aldor007 Could you rebase your branch on master so the CI can run again?

kong/plugins/prometheus/exporter.lua Outdated Show resolved Hide resolved
@aldor007
Copy link
Contributor Author

@fffonion
PR updated

@aldor007 aldor007 requested a review from fffonion March 17, 2020 06:37
@hbagdi hbagdi merged commit a3c7c72 into Kong:master Mar 17, 2020
@Symbianx Symbianx mentioned this pull request Dec 15, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fffonion fffonion fffonion approved these changes

@mpacholec mpacholec mpacholec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aldor007 @mpacholec @fffonion @hbagdi