This repository has been archived by the owner on Nov 30, 2021. It is now read-only.
feat/request tags #102
Merged
feat/request tags #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When developing locally, `ZIPKIN_HOST=localhost bin/busted ...` can be used.
kikito
force-pushed
the
feat/request-tags
branch
from
740b6fe
to
dffd1e0
Compare
gszr
approved these changes
Feb 11, 2021
| end | ||
|
|
||
| local t = type(tags_header) | ||
| local tags, errors = {}, {} |
There was a problem hiding this comment.
we could probably use new_tab with a reasonable size, and perhaps cache parsed tags, but I would leave that as future improvements
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows inserting custom tags on the Zipkin request trace by adding specific headers to the request.
The header is customizable via config (defaults to
Zipkin-Tags).The tags must have the following syntax:
Implements #97