This repository has been archived by the owner on Nov 30, 2021. It is now read-only.
Don't send span.kind tag #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-callahan
force-pushed
the
no-kind-span
branch
2 times, most recently
from
01d4b9d
to
b3356ad
Compare
james-callahan
force-pushed
the
no-kind-span
branch
2 times, most recently
from
f8b1a73
to
bb865fb
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
span.kindis redundant,kindis a top level field in zipkin v2peer.*are also redundant: they are in*Endpointfields.Although these don't break anything, it uses up storage and indexing.
Thanks @adriancole