This repository has been archived by the owner on Nov 30, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first plugin to support the stream subsystem, as such some questions have arisen:
In this case, I just implemented different
:preread
vs:rewrite
+:access
+etc phasesThey purposefully share a log phase
The other question raised by this PR is how to actually propagate tracing contexts in TLS. https://github.com/w3c/trace-context/issues/198 remains unresolved, so this PR currently sets the wire context to
nil
, I intend to improve on that in a separate PR for the limited use case of kong mesh.