This repository has been archived by the owner on Nov 30, 2021. It is now read-only.
fixes: http.path and span name #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hishamhm
approved these changes
Nov 6, 2019
kikito
commented
Nov 6, 2019
This is to avoid leaking private information like tokens or API keys.
We name spans for http traffic `GET` instead of `GET http://foo.bar/baz` in order to avoid high cardinality. See #52 (review)
kikito
force-pushed
the
fix/zipkin-span-names-and-url
branch
from
15c7e32
to
e8b8644
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes 3 fixes:
travis.ymlwhich (possibly) made CI fail on certain setupshttp.pathinstead ofhttp.url(fix: fixes the path #56)GETinstead ofGET http://foo.bar/bazThe last two changes are discussed in #52.