chore: bump electron 31 [INS-4037] (#42)

* chore: bump electron 31 [INS-4037] * trigger ci * update CopyablePersistentTraits * fix? * fix2? * fix3? * bump to latest 31.4 * remove Nan -> v8 workarounds * skip the upload/download curly test * fork electron-mocha * pin runners * bump version --------- Co-authored-by: jackkav <jackkav@gmail.com>
Kong · Aug 28, 2024 · 8bceb59 · 8bceb59
1 parent e86d263
commit 8bceb59
Show file tree

Hide file tree

Showing 9 changed files with 122 additions and 115 deletions.
diff --git a/.github/workflows/build-and-release.yaml b/.github/workflows/build-and-release.yaml
@@ -46,14 +46,14 @@ jobs:
       fail-fast: false
       matrix:
         os:
-          - macos-latest
-          - ubuntu-latest
+          - macos-13
+          - ubuntu-22.04
         libcurl-release:
           - 7.79.1
         node-libcurl-cpp-std:
           - c++17
         node:
-          - 20.11.1
+          - 20.16.0
 
     env:
       LIBCURL_RELEASE: ${{ matrix.libcurl-release }}
@@ -105,14 +105,14 @@ jobs:
       fail-fast: false
       matrix:
         os:
-          - macos-latest
-          - ubuntu-latest
+          - macos-13
+          - ubuntu-22.04
         libcurl-release:
           - 7.79.1
         node:
-          - 20.11.1
+          - 20.16.0
         electron-version:
-          - 30.0.0
+          - 31.4.0
     env:
       LIBCURL_RELEASE: ${{ matrix.libcurl-release }}
       LATEST_LIBCURL_RELEASE: ${{ matrix.libcurl-release }}
@@ -173,7 +173,7 @@ jobs:
       fail-fast: false
       matrix:
         node:
-          - 20.11.1
+          - 20.16.0
     env:
       npm_config_msvs_version: 2022
       npm_config_build_from_source: true
@@ -216,9 +216,9 @@ jobs:
       fail-fast: false
       matrix:
         node:
-          - 20.11.1
+          - 20.16.0
         electron-version:
-          - 30.0.0
+          - 31.4.0
     env:
       ELECTRON_VERSION: ${{ matrix.electron-version }}
       npm_config_msvs_version: 2022

diff --git a/.github/workflows/build-lint-test.yaml b/.github/workflows/build-lint-test.yaml
@@ -40,18 +40,18 @@ jobs:
       fail-fast: false
       matrix:
         os:
-          - macos-latest
-          - ubuntu-latest
+          - macos-13
+          - ubuntu-22.04
         libcurl-release:
           - 7.79.1
         node-libcurl-cpp-std:
           - c++17
         node:
-          - 20.11.1
+          - 20.16.0
         include:
           # Lint
           - os: ubuntu-latest
-            node: 20.11.1
+            node: 20.16.0
             node-libcurl-cpp-std: c++17
             libcurl-release: 7.79.1
             run-lint-and-tsc: true
@@ -138,14 +138,14 @@ jobs:
       fail-fast: false
       matrix:
         os:
-          - macos-latest
-          - ubuntu-latest
+          - macos-13
+          - ubuntu-22.04
         libcurl-release:
           - 7.79.1
         node:
-          - 20.11.1
+          - 20.16.0
         electron-version:
-          - 30.0.0
+          - 31.4.0
     env:
       LIBCURL_RELEASE: ${{ matrix.libcurl-release }}
       LATEST_LIBCURL_RELEASE: ${{ matrix.libcurl-release }}
@@ -221,7 +221,7 @@ jobs:
       fail-fast: false
       matrix:
         node:
-          - 20.11.1
+          - 20.16.0
     env:
       npm_config_msvs_version: 2022
       npm_config_build_from_source: true
@@ -258,9 +258,9 @@ jobs:
       fail-fast: false
       matrix:
         node:
-          - 20.11.1
+          - 20.16.0
         electron-version:
-          - 30.0.0
+          - 31.4.0
     env:
       ELECTRON_VERSION: ${{ matrix.electron-version }}
       npm_config_msvs_version: 2022

diff --git a/.github/workflows/publish.yaml b/.github/workflows/publish.yaml
@@ -19,7 +19,7 @@ jobs:
       - name: Setup Node.js
         uses: actions/setup-node@v3
         with:
-          node-version: 20.11.1
+          node-version: 20.16.0
           registry-url: 'https://registry.npmjs.org'
       - name: Install
         run: npm ci --ignore-scripts

diff --git a/.nvmrc b/.nvmrc
@@ -1 +1 @@
-20.11.1
+20.16.0