fix: localhost resolution RFC6761 #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filfreire
force-pushed
the
spike/investigate-localhost-rfc6761
branch
from
aab6868 to
ee15841
Compare
1 task
filfreire
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to investigate Kong/insomnia#8160 and if it's potentially an issue on node-libcurl side
Bumps to libcurl
7.86.0where the fix was introduced. Not bumping to any higher libcurl version for now to avoid dragons.Research:
Note: Windows still fails on the⚠️ Update on windows: we're dependant on https://github.com/JCMais/curl-for-windows - the git submodule was pointing at an older commit. Regardless of version set on linux and macos. Latest commit on that repo has since pulled to curl 7.86.0
test.localhostscenario, even though using curl 7.85.0 on a Windows machine works, not sure what's the reason for it to fail here 🤷♂️ Looks like there's more weirdness there potentially.