feat: enable-legacy and enable-weak-ssl-ciphers #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filfreire
reviewed
Nov 26, 2024
| @@ -57,7 +57,7 @@ if [ "$MACOS_UNIVERSAL_BUILD" == "true" ]; then | |||
| -fPIC \ | |||
| --prefix=$build_folder \ | |||
| --openssldir=$build_folder \ | |||
| no-tests no-shared "${@:2}" | |||
| no-tests no-shared enable-legacy enable-weak-ssl-ciphers "${@:2}" | |||
There was a problem hiding this comment.
@notjaywu we will also need to enable these on the curl-for-windows fork, and then pull the latest on the git submodule - otherwise here they are only enabled for MacOS and Linux
There was a problem hiding this comment.
yes, this is another pr notjaywu/curl-for-windows#1
filfreire
approved these changes
Nov 26, 2024
notjaywu
changed the title
This was referenced Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taking another pass at #69, this time doing the change also on the curl-for-windows fork
Related to INS-4508