Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to INS-4508
Trying to have a reproduction on the tests.
Investigation
enable-legacy
andenable-weak-ssl-ciphers
notjaywu/curl-for-windows@2908ea5 🔴 doesn't work - the edited Makefile is not used for windows (https://github.com/Kong/node-libcurl/releases/tag/v2.31.5-alpha.0).cnf
files notjaywu/curl-for-windows@master...Kong:curl-for-windows:master 🔴 doesn't work - same as above - the file isn't used (https://github.com/Kong/node-libcurl/releases/tag/v2.31.5-alpha.1)Related to image above, maybe we are close ? The legacy related ciphers seem to be included now in the build when openssl is being built, but it doesn't seem to be useful for curl itself
Ideas to explore
Suggestion
We should go with Option B and C of INS-4508
Even if we find a way to enable legacy and weak ciphers on openssl and make it work for libcurl - we are going down a path where we need to maintain curl-for-windows submodule - and on top of that - keep each submodule in that repository, like curl, openssl, brotli, .... up-to-date on Windows, just to have parity between curl version used for MacOS and Linux and the one used for Windows.
Not even
curl
supports this it seems, looking at curl/curl#8966 - so we should probably avoid going this route.related research